[GitHub] [iceberg] pvary commented on pull request #8547: HIVE: Fix the Hive version checking in MetastoreLock logical error

["pvary (via GitHub)" <gi...@apache.org>]

pvary commented on PR #8547:
URL: https://github.com/apache/iceberg/pull/8547#issuecomment-1714970878

   @Paddy0523: I think, as a result of this bug, the `fndLock` method was never called in case of the Hive version being higher than 2. Am I right here?
   
   After the fix it will be correctly called.
   Could we add assertion(s) to existing tests, that the `fibdLocks` is called when expected too.
   
   Thanks for taking care of this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org