[jira] [Commented] (AIRFLOW-4983) DataflowPythonOperator should be able to submit pipelines with python3

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887343#comment-16887343 ] 

ASF GitHub Bot commented on AIRFLOW-4983:
-----------------------------------------

jaketf commented on pull request #5602: [AIRFLOW-4983] Feature/dataflow operator python3
URL: https://github.com/apache/airflow/pull/5602
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4983
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Adding a `py_interpreter` argument to `DataflowHook` and `DataflowOperator` which can be set to `'python2'` or `'python3'`
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   ```
   test_start_python2_dataflow # tests explicitly passing py_version='python2'
   test_start_python3_dataflow # tests explicitly passing py_version='python2'
   test_start_python_dataflow_bad_version # tests error handling for unsupported py_version
   ```
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DataflowPythonOperator should be able to submit pipelines with python3
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-4983
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4983
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp, hooks, operators
>    Affects Versions: 1.10.2, 1.10.4, 2.0.0, 1.10.5
>            Reporter: Jacob Ferriero
>            Assignee: Jacob Ferriero
>            Priority: Minor
>
> Currently the DataflowHook hard codes python2 interpreter.
> Apache Beam is beginning to support python3 interpreter and we should support submitting those pipelines.
> I've we should add a `py_interpreter` arg to the operator and hook that defaults to 'python2' (to not be interface breaking.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)