[GitHub] [rocketmq] RongtongJin edited a comment on issue #1331: [ISSUE #1304] implement the method of putMessage to support batch message and add an unit test

[GitBox <gi...@apache.org>]

RongtongJin edited a comment on issue #1331: [ISSUE #1304] implement the method of putMessage to support batch message and add an unit test
URL: https://github.com/apache/rocketmq/pull/1331#issuecomment-514611626
 
 
   @qqeasonchen Thanks for submitting.  
   1. First and foremost，the code implementation is Wrong. Without judging the result of any append, you should not assume that all the messages were added successfully. In my opinion, The support for batch messages (RocketMQ on DLedger) requires more rigorous consideration, and you can't split the messages and then call append API of DLedger simply. 
   2. About code style . If you use IDEA, you can reformat code to pass the check style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services