You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@avalon.apache.org by bl...@apache.org on 2003/03/17 21:23:00 UTC

cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role AbstractRoleManager.java ConfigurableRoleManager.java

bloritsch    2003/03/17 12:22:57

  Modified:    fortress/src/java/org/apache/avalon/fortress/impl/role
                        AbstractRoleManager.java
                        ConfigurableRoleManager.java
  Removed:     cache    .cvsignore README.txt ant.properties.sample
                        build.xml default.properties
               cache/src/java/org/apache/excalibur/cache Cache.java
                        CacheEvent.java CacheListener.java CacheStore.java
                        CacheValidator.java ReplacementPolicy.java
                        SynchronizedCache.java ValidatingCache.java
                        package.html
               cache/src/java/org/apache/excalibur/cache/doc-files
                        cache.dia cache.png
               cache/src/java/org/apache/excalibur/cache/impl
                        AbstractCache.java DefaultCache.java LRUCache.java
                        TimeMapLRUCache.java
               cache/src/java/org/apache/excalibur/cache/policy
                        FIFOPolicy.java LRUPolicy.java ListBasedPolicy.java
                        TimeMapLRUPolicy.java
               cache/src/java/org/apache/excalibur/cache/store
                        AbstractCacheStore.java FlipSpacesStore.java
                        MemoryStore.java
               cache/src/java/org/apache/excalibur/cache/validator
                        AndValidator.java TimeoutValidator.java
               cache/src/test/org/apache/excalibur/cache/impl/test
                        AbstractCacheTestCase.java LRUCacheTestCase.java
                        TimeMapLRUCacheTestCase.java
               cache/src/test/org/apache/excalibur/cache/store/test
                        AbstractCacheStoreTestCase.java
                        MemoryStoreTestCase.java
               cache/src/test/org/apache/excalibur/cache/validator/test
                        TimeoutValidatorTestCase.java
               cache/src/xdocs book.xml index.xml tabs.xml
               cache/src/xdocs/images cache.dia cache.png
  Log:
  remove cache because it has been moved to sandbox
  
  Revision  Changes    Path
  1.4       +10 -6     avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role/AbstractRoleManager.java
  
  Index: AbstractRoleManager.java
  ===================================================================
  RCS file: /home/cvs/avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role/AbstractRoleManager.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- AbstractRoleManager.java	25 Feb 2003 15:23:47 -0000	1.3
  +++ AbstractRoleManager.java	17 Mar 2003 20:22:56 -0000	1.4
  @@ -49,6 +49,10 @@
   */
   package org.apache.avalon.fortress.impl.role;
   
  +import java.util.HashMap;
  +import java.util.Map;
  +
  +import org.apache.avalon.fortress.RoleManager;
   import org.apache.avalon.framework.logger.AbstractLogEnabled;
   
   /**
  @@ -64,24 +68,24 @@
       implements org.apache.avalon.fortress.RoleManager
   {
      /**
  -    * The classloader
  +    * The classloader used to load and check roles and components.
       */
  -    private final ClassLoader m_loader;
  +    protected final ClassLoader m_loader;
   
       /**
        * Map for shorthand to RoleEntry
        */
  -    private java.util.Map m_shorthands = new java.util.Hashtable();
  +    private Map m_shorthands = new HashMap();
   
       /**
        * Map for classname to RoleEntry
        */
  -    private java.util.Map m_classnames = new java.util.Hashtable();
  +    private Map m_classnames = new HashMap();
   
       /**
        * Parent <code>RoleManager</code> for nested resolution
        */
  -    private final org.apache.avalon.fortress.RoleManager m_parent;
  +    private final RoleManager m_parent;
   
       /**
        * Default constructor--this RoleManager has no parent.
  
  
  
  1.4       +5 -4      avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role/ConfigurableRoleManager.java
  
  Index: ConfigurableRoleManager.java
  ===================================================================
  RCS file: /home/cvs/avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role/ConfigurableRoleManager.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ConfigurableRoleManager.java	25 Feb 2003 15:23:47 -0000	1.3
  +++ ConfigurableRoleManager.java	17 Mar 2003 20:22:57 -0000	1.4
  @@ -49,6 +49,7 @@
   */
   package org.apache.avalon.fortress.impl.role;
   
  +import org.apache.avalon.fortress.RoleManager;
   import org.apache.avalon.framework.configuration.Configurable;
   import org.apache.avalon.framework.configuration.Configuration;
   import org.apache.avalon.framework.configuration.ConfigurationException;
  @@ -63,7 +64,7 @@
    * @since 4.1
    */
   public class ConfigurableRoleManager
  -    extends org.apache.avalon.fortress.impl.role.AbstractRoleManager
  +    extends AbstractRoleManager
       implements Configurable
   {
       /**
  @@ -80,7 +81,7 @@
        *
        * @param parent  The parent <code>RoleManager</code>.
        */
  -    public ConfigurableRoleManager( org.apache.avalon.fortress.RoleManager parent )
  +    public ConfigurableRoleManager( RoleManager parent )
       {
           super( parent, null );
       }
  @@ -92,7 +93,7 @@
        * @param parent The parent <code>RoleManager</code>.
        * @param loader the classloader
        */
  -    public ConfigurableRoleManager( org.apache.avalon.fortress.RoleManager parent, ClassLoader loader )
  +    public ConfigurableRoleManager( RoleManager parent, ClassLoader loader )
       {
           super( parent, loader );
       }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@avalon.apache.org
For additional commands, e-mail: cvs-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role AbstractRoleManager.java ConfigurableRoleManager.java

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> On Tue, 18 Mar 2003 07:36, Berin Loritsch wrote:
> 
>>Peter Donald wrote:
>>
>>>any reason for making variable protected?
>>
>>Yep.  
> 
> 
> Okay - maybe I should state is there any reason for making this variable 
> protected and not manipulating via setter/getters?

Sure, we can use a protected getter().


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role AbstractRoleManager.java ConfigurableRoleManager.java

Posted by Peter Donald <pe...@realityforge.org>.
On Tue, 18 Mar 2003 07:36, Berin Loritsch wrote:
> Peter Donald wrote:
> > any reason for making variable protected?
>
> Yep.  

Okay - maybe I should state is there any reason for making this variable 
protected and not manipulating via setter/getters?

-- 
Cheers,

Peter Donald
---------------------------------------------------
"Therefore it can be said that victorious warriors 
win first, and then go to battle, while defeated 
warriors go to battle first, and then seek to win." 
              - Sun Tzu, the Art Of War
--------------------------------------------------- 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role AbstractRoleManager.java ConfigurableRoleManager.java

Posted by Berin Loritsch <bl...@apache.org>.
Peter Donald wrote:
> 
> any reason for making variable protected?

Yep.  I have need to extend this RoleManager with another one in the
GUIApp project.  If I can finish with that implementation I can make
the RoleManager work with @attributes.  I already have some ANT tasks
to make things work nicely.

It will be minimal, but a nicer first step away from ECM because
users will already be using meta data.

The two pieces of information I need to keep track of are:

Shorthand name (i.e. configuration alias)
Component Handler (i.e. lifestyle)

I would like us to discuss the name for expressing the lifestyle.

Of all the schemes that have been proposed so far, I like the one
that expresses lifestyle in terms of scope.

Scope     |   Lifestyle
----------+-----------------
Container | ThreadSafe
Thread    | PerThread
Request   | Pooled

There would be no direct mapping to the factory version--it would
have to be accessed via a fortress specific component-handler
attribute.

This is a far cry from Phoenix and Merlin's full component validation,
but it gets our users away from the explicit RoleManager paradigm and
more used to metadata.

I just need to finish what I am doing with it.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/role AbstractRoleManager.java ConfigurableRoleManager.java

Posted by Peter Donald <pe...@realityforge.org>.
On Tue, 18 Mar 2003 07:23, bloritsch@apache.org wrote:
>   Index: AbstractRoleManager.java
>   ===================================================================
>   RCS file:
> /home/cvs/avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/imp
>l/role/AbstractRoleManager.java,v retrieving revision 1.3
>   retrieving revision 1.4
>   diff -u -r1.3 -r1.4
>   --- AbstractRoleManager.java	25 Feb 2003 15:23:47 -0000	1.3
>   +++ AbstractRoleManager.java	17 Mar 2003 20:22:56 -0000	1.4
>   @@ -49,6 +49,10 @@
>    */
>    package org.apache.avalon.fortress.impl.role;
>
>   +import java.util.HashMap;
>   +import java.util.Map;
>   +
>   +import org.apache.avalon.fortress.RoleManager;
>    import org.apache.avalon.framework.logger.AbstractLogEnabled;
>
>    /**
>   @@ -64,24 +68,24 @@
>        implements org.apache.avalon.fortress.RoleManager
>    {
>       /**
>   -    * The classloader
>   +    * The classloader used to load and check roles and components.
>        */
>   -    private final ClassLoader m_loader;
>   +    protected final ClassLoader m_loader;

any reason for making variable protected?

-- 
Cheers,

Peter Donald
Duct tape is like the force.  It has a light side, and a dark side, and
it binds the universe together ...
                -- Carl Zwanzig 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org