[jira] [Commented] (HBASE-17448) Export metrics from RecoverableZooKeeper

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381184#comment-16381184 ] 

Andrew Purtell commented on HBASE-17448:
----------------------------------------

HBASE-19769 pulled this from 2.0.  The following were discussed as motivations:

- Issues with service loading in YARN, IllegalAccess exceptions
- Too verbose (? - they are metrics)
- Dont' want stuff based on hadoop-metrics

All valid.

Although this shipped in 1.4.0, 1.4.1, and 1.4.2, I have no problem pulling it from 1.5 if problematic, or even from 1.4.3 if more than problematic approaching broken. Please advise. 

My thinking at this time is it should get pulled from 1.5 since it has already been pulled from 2.0. 

> Export metrics from RecoverableZooKeeper
> ----------------------------------------
>
>                 Key: HBASE-17448
>                 URL: https://issues.apache.org/jira/browse/HBASE-17448
>             Project: HBase
>          Issue Type: Improvement
>          Components: Zookeeper
>    Affects Versions: 1.3.1
>            Reporter: Andrew Purtell
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>              Labels: patch
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17448-branch-1.patch, HBASE-17448.patch, HBASE-17448.patch
>
>
> Consider adding instrumentation to RecoverableZooKeeper that exposes metrics on the performance and health of the embedded ZooKeeper client: latency histograms for each op type, number of reconnections, number of ops where a reconnection was necessary to proceed, number of failed ops due to CONNECTIONLOSS, number of failed ops due to SESSIONEXIPRED, number of failed ops due to OPERATIONTIMEOUT. 
> RecoverableZooKeeper is a class in hbase-client so we can hook up the new metrics to both client- and server-side metrics reporters. Probably this metrics source should be a process singleton. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)