You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/17 10:18:37 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #18068: [fix][ci] Ensure to run setup method in SimpleProducerConsumerTest
nicoloboschi opened a new pull request, #18068:
URL: https://github.com/apache/pulsar/pull/18068
### Motivation
After https://github.com/apache/pulsar/pull/17887 there are a lot of failures in the CI
```
java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.broker.PulsarService.getConfiguration()" because "this.pulsar" is null
at org.apache.pulsar.client.api.SimpleProducerConsumerTest.rest(SimpleProducerConsumerTest.java:138)
```
```
java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.client.api.PulsarClient.newConsumer()" because "this.pulsarClient" is null
at org.apache.pulsar.client.api.SimpleProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect(SimpleProducerConsumerTest.java:880)
```
The reason is that the after method is always executed meanwhile the setup method is not+
### Modifications
* Add back `alwaysRun=true` in the setup method
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #18068: [fix][ci] Ensure to run setup method in SimpleProducerConsumerTest
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #18068:
URL: https://github.com/apache/pulsar/pull/18068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18068: [fix][ci] Ensure to run setup method in SimpleProducerConsumerTest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18068:
URL: https://github.com/apache/pulsar/pull/18068#issuecomment-1281699361
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18068?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@92b4708`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18068 +/- ##
=========================================
Coverage ? 70.88%
Complexity ? 438
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1592
Misses ? 481
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.88% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #18068: [fix][ci] Ensure to run setup method in SimpleProducerConsumerTest
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18068: [fix][ci] Ensure to run setup method in SimpleProducerConsumerTest
URL: https://github.com/apache/pulsar/pull/18068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org