[jira] [Commented] (BEAM-2795) FlinkRunner: translate using SDK-agnostic means

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310568#comment-16310568 ] 

ASF GitHub Bot commented on BEAM-2795:
--------------------------------------

bsidhom opened a new pull request #4343: [BEAM-2795] Use portable constructs in Flink batch translator
URL: https://github.com/apache/beam/pull/4343
 
 
   This was tested by round-tripping batch pipelines to and from protobuf form. It works with both real Java pipelines and rehydrated pipelines.
   
   References and downcasts to specific transform subclasses are replaced with generic `PTransform`s. Transform metadata is now accessed through the translation utilities under `org.apache.beam.runners.core.construction`.
   
   `CombineTranslation` uses a new side input extractor modeled after `ParDoTranslation#getSideInputs`.
   
   The `RawCombine` rehydrated transform exposes side inputs via `getAdditionalInputs`. Side inputs were not previously exposed as "additional" inputs, so `FlinkBatchTranslationContext#getInput` could not properly extract the main output collection when side inputs were used.
   
   The `ParDo` union coder is picky about ordering. It appears that coders must appear at the same indexes as their respective output collection tags. This ordering is now preserved.
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> FlinkRunner: translate using SDK-agnostic means
> -----------------------------------------------
>
>                 Key: BEAM-2795
>                 URL: https://issues.apache.org/jira/browse/BEAM-2795
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-flink
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: portability
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)