You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Andrew Black <ab...@roguewave.com> on 2006/10/30 22:49:47 UTC
[PATCH] Locale testing exit handling
Greetings all
Attached is a small patch that attempts to fix a bug observed on HPUX
11.23 during automated testing. The problem being observed is that the
the temporary directory used in the locale testing process isn't being
cleaned up correctly upon being killed by the exec utility.
Unfortunately, I have found it difficult to replicate this bug during
manual testing, and I am uncertain if this patch actually resolves the
issue.
--Andrew Black
Changelog
* run_locale_utils (terminate): Add flag variable to signify if script
is exiting
(cleanup): if terminate flag is set to 0, set to 1 and exit
Re: [PATCH] Locale testing exit handling
Posted by Martin Sebor <se...@roguewave.com>.
Andrew Black wrote:
> Greetings all
>
> Attached is a small patch that attempts to fix a bug observed on HPUX
> 11.23 during automated testing. The problem being observed is that the
> the temporary directory used in the locale testing process isn't being
> cleaned up correctly upon being killed by the exec utility.
Yes, I was wrestling with the same problem before my trip. Thanks
for looking into it!
> Unfortunately, I have found it difficult to replicate this bug during
> manual testing, and I am uncertain if this patch actually resolves the
> issue.
Umm, then why bother applying it?
I think we need to understand the problem first. The best way to
get the understanding is to reproduce the issue in a small test
case.
[...]
> @@ -474,6 +472,11 @@
> debug_output "rm -rf $tmpdir"
> rm -rf $tmpdir
> fi
> + if (( 0 == terminate )); then
What syntax is this?
Martin