You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/02 09:57:17 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #8144:
[FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode
tillrohrmann commented on a change in pull request #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode
URL: https://github.com/apache/flink/pull/8144#discussion_r280351583
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -869,41 +859,40 @@ public ApplicationReport startAppMaster(
FsPermission permission = new FsPermission(FsAction.ALL, FsAction.NONE, FsAction.NONE);
fs.setPermission(yarnFilesDir, permission); // set permission for path.
+ Path remoteYarnSiteXmlPath = null;
+ File f = new File(System.getenv("YARN_CONF_DIR"), Utils.YARN_SITE_FILE_NAME);
+ LOG.info("Adding Yarn configuration {} to the AM container local resource bucket", f.getAbsolutePath());
+ Path yarnSitePath = new Path(f.getAbsolutePath());
+ remoteYarnSiteXmlPath = setupSingleLocalResource(
+ Utils.YARN_SITE_FILE_NAME,
+ fs,
+ appId,
+ yarnSitePath,
+ localResources,
+ homeDir,
+ "");
Review comment:
This is not what I proposed. We should not add the `yarn-site.xml` per default to all Yarn deployments. Instead we should only add it if we are using the `YarnTestBase`. Therefore, I suggest to add
```
yarnClusterDescriptor.addShipFiles(Arrays.asList(flinkLibFolder, yarnSiteXMLFile));
```
to `YarnTestBase#createYarnClusterDescriptor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services