You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/24 00:03:35 UTC

[GitHub] [kafka] vitojeng opened a new pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

vitojeng opened a new pull request #9069:
URL: https://github.com/apache/kafka/pull/9069


   follow-up #8200 
   
   KAFKA-5876's PR break into multiple parts, this PR is part 2: apply UnknownStateStoreException 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng commented on a change in pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

Posted by GitBox <gi...@apache.org>.
vitojeng commented on a change in pull request #9069:
URL: https://github.com/apache/kafka/pull/9069#discussion_r459805054



##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -693,6 +695,16 @@ public void shouldNotGetQueryMetadataWithPartitionerWhenNotRunningOrRebalancing(
         streams.queryMetadataForKey("store", "key", (topic, key, value, numPartitions) -> 0);
     }
 
+    @Test(expected = UnknownStateStoreException.class)

Review comment:
       I am not sure if using annotation is a good choice. Would it be better to use `assertThrows` ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng closed pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

Posted by GitBox <gi...@apache.org>.
vitojeng closed pull request #9069:
URL: https://github.com/apache/kafka/pull/9069


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org