[GitHub] astefanutti commented on a change in pull request #442: Add field 'camel-version' to Integration CRD

[GitBox <gi...@apache.org>]

astefanutti commented on a change in pull request #442: Add field 'camel-version' to Integration CRD
URL: https://github.com/apache/camel-k/pull/442#discussion_r257270198
 
 

 ##########
 File path: pkg/trait/gc.go
 ##########
 @@ -109,7 +113,12 @@ func getOldGenerationResources(e *Environment) ([]unstructured.Unstructured, err
 		return nil, err
 	}
 
-	selector, err := labels.Parse(fmt.Sprintf("camel.apache.org/integration=%s,camel.apache.org/generation,camel.apache.org/generation notin (%d)", e.Integration.Name, e.Integration.GetGeneration()))
+	selectors := []string{
+		fmt.Sprintf("camel.apache.org/integration=%s", e.Integration.Name),
+		fmt.Sprintf("camel.apache.org/generation,camel.apache.org/generation notin (%d)", e.Integration.GetGeneration()),
+	}
 
 Review comment:
   @lburgazzoli I knew that line was way too long 😉! While we are at it, you could split the second selector as well for consistency. Otherwise LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services