[GitHub] [spark] LuciferYang commented on pull request #42501: [SPARK-44806][CONNECT] Move internal client spark-connect-common to be able to test real in-process server with a real RPC client

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on PR #42501:
URL: https://github.com/apache/spark/pull/42501#issuecomment-1680508614

   I need to give this a bit more thought to fully grasp the benefits of this approach. At first blush, it seems off to me to place code that's only used in the client into the common module, even though it's also used by the server module during testing. Maybe we could consider a name change for the `common` module, to better capture what it does?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org