You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by pengyuewu <gi...@git.apache.org> on 2017/01/12 10:48:47 UTC

[GitHub] incubator-trafficcontrol pull request #184: fix the issue failed to delete s...

GitHub user pengyuewu opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/184

    fix the issue failed to delete sslkeys by TrafficOps API

    @dneuman64 
    I open a issue : https://issues.apache.org/jira/browse/TC-98
    
    1. I tried to delete SSL keys by API for Delivery Services: https001 as follows:
    /api/1.1/deliveryservices/xmlId/https001/sslkeys/delete.json
    2.The result was failure, the sslkey for https001 stilled in Traffic Vault.
    
    3. The root cause is the delete function in traffic_ops/app/lib/Connection/RiakAdapter.pm

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pengyuewu/incubator-trafficcontrol 1.7.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #184
    
----
commit 5941414bcc473329d3b608847067e5fa71e74616
Author: pengyuewu <pe...@cisco.com>
Date:   2017-01-12T10:42:34Z

    fix the issue failed to delete sslkeys by TrafficOps API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #184: fix the issue failed to delete s...

Posted by pengyuewu <gi...@git.apache.org>.

Github user pengyuewu closed the pull request at:

    https://github.com/apache/incubator-trafficcontrol/pull/184


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #184: fix the issue failed to delete sslkeys ...

Posted by dneuman64 <gi...@git.apache.org>.

Github user dneuman64 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/184
  
    Hey @pengyuewu, it looks like this PR is against 1.7.x which was released before apache.  We don't have any plans on releasing another version of 1.7.  Can you re-test this defect against master and, if it still exists, create a PR against master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #184: fix the issue failed to delete sslkeys ...

Posted by pengyuewu <gi...@git.apache.org>.

Github user pengyuewu commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/184
  
    OK,it still exists in master,I'll create a PR against master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---