You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/17 14:30:53 UTC
[GitHub] [trafficcontrol] mitchell852 opened a new pull request, #6837: TP expired DS certs: adds color coding to expired and soon-expired certs
mitchell852 opened a new pull request, #6837:
URL: https://github.com/apache/trafficcontrol/pull/6837
## Which Traffic Control components are affected by this PR?
- Traffic Portal
## What is the best way to verify this PR?
- Start TP
- Navigate to https://tp.domain.tld/#!/cert-expirations
- Expired certs will have a red row
- Soon expired certs (30 days or less) will have a yellow row
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a diff in pull request #6837: TP expired DS certs: adds color coding to expired and soon-expired certs
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on code in PR #6837:
URL: https://github.com/apache/trafficcontrol/pull/6837#discussion_r880677055
##########
traffic_portal/app/src/common/modules/table/certExpirations/TableCertExpirationsController.js:
##########
@@ -84,6 +84,17 @@ var TableCertExpirationsController = function(tableName, certExpirations, $scope
// Event is outside the digest cycle, so we need to trigger one.
$scope.$apply();
}
+ },
+ rowClassRules: {
+ 'expired-cert': function(params) {
+ let now = new Date();
+ return params.data.expiration < now;
+ },
+ 'soon-expired-cert': function(params) {
+ let thirtyDays = new Date();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6837: TP expired DS certs: adds color coding to expired and soon-expired certs
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6837:
URL: https://github.com/apache/trafficcontrol/pull/6837#discussion_r879829174
##########
traffic_portal/app/src/common/modules/table/certExpirations/TableCertExpirationsController.js:
##########
@@ -84,6 +84,17 @@ var TableCertExpirationsController = function(tableName, certExpirations, $scope
// Event is outside the digest cycle, so we need to trigger one.
$scope.$apply();
}
+ },
+ rowClassRules: {
+ 'expired-cert': function(params) {
+ let now = new Date();
+ return params.data.expiration < now;
+ },
+ 'soon-expired-cert': function(params) {
+ let thirtyDays = new Date();
Review Comment:
nit: `now` and `thirtyDays` are never reassigned, could be `const`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6837: TP expired DS certs: adds color coding to expired and soon-expired certs
Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6837:
URL: https://github.com/apache/trafficcontrol/pull/6837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org