[jira] [Commented] (MESOS-8576) Improve discard handling of 'Docker::inspect()'

["Gilbert Song (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384340#comment-16384340 ] 

Gilbert Song commented on MESOS-8576:
-------------------------------------

{noformat}
commit 8346ab0c812559ef73e1bbd30718f6c74a023079
Author: Greg Mann <gr...@mesosphere.io>
Date:   Fri Mar 2 15:39:58 2018 -0800


    Avoided orphan subprocess in the Docker library.

    
    This patch ensures that `Docker::inspect` will not leave orphan
    subprocesses behind.
    

    Review: https://reviews.apache.org/r/65887/

{noformat}

> Improve discard handling of 'Docker::inspect()'
> -----------------------------------------------
>
>                 Key: MESOS-8576
>                 URL: https://issues.apache.org/jira/browse/MESOS-8576
>             Project: Mesos
>          Issue Type: Improvement
>          Components: containerization, docker
>    Affects Versions: 1.5.0
>            Reporter: Greg Mann
>            Assignee: Greg Mann
>            Priority: Major
>              Labels: mesosphere
>             Fix For: 1.6.0
>
>
> In the call path of {{Docker::inspect()}}, each continuation currently checks if {{promise->future().hasDiscard()}}, where the {{promise}} is associated with the output of the {{docker inspect}} call. However, if the call to {{docker inspect}} becomes hung indefinitely, then continuations are never invoked, and a subsequent discard of the returned {{Future}} will have no effect. We should add proper {{onDiscard}} handling to that {{Future}} so that appropriate cleanup is performed in such cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)