[GitHub] [ignite-3] sashapolo commented on a change in pull request #297: IGNITE-15338 Return null if a DataRow is not found

[GitBox <gi...@apache.org>]

sashapolo commented on a change in pull request #297:
URL: https://github.com/apache/ignite-3/pull/297#discussion_r701776359



##########
File path: modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorage.java
##########
@@ -462,7 +472,7 @@ private ScanCursor(RocksIterator iter, Predicate<SearchRow> filter) {
 
         /** {@inheritDoc} */
         @Override public boolean hasNext() {
-            while (isValid() && !filter.test(new SimpleDataRow(iter.key(), null)))
+            while (isValid() && !filter.test(new SimpleDataRow(iter.key(), iter.value())))

Review comment:
       why is it bad? There's a way, but we would need to introduce an implementation of `SearchRow`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org