You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/01/16 20:59:49 UTC
Review Request 16983: Fix maintenance command documentation and
host/filename logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/
-----------------------------------------------------------
Review request for Aurora and Jonathan Boulle.
Repository: aurora
Description
-------
Fix maintenance command documentation and host/filename logic.
Diffs
-----
src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
Diff: https://reviews.apache.org/r/16983/diff/
Testing
-------
Thanks,
Joe Smith
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Jonathan Boulle <jo...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32179
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Boulle
On Jan. 16, 2014, 9:17 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 9:17 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32079
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 16, 2014, 9:17 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 9:17 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Tobias Weingartner <tw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32081
-----------------------------------------------------------
Ship it!
Ship It!
- Tobias Weingartner
On Jan. 16, 2014, 9:17 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 9:17 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 1:17 p.m.)
Review request for Aurora, Jonathan Boulle and Bill Farner.
Changes
-------
Improved logic handling for host specification thanks to Bill.
Repository: aurora
Description
-------
Fix maintenance command documentation and host/filename logic.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
Diff: https://reviews.apache.org/r/16983/diff/
Testing
-------
Thanks,
Joe Smith
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Joe Smith <ya...@gmail.com>.
> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 38
> > <https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38>
> >
> > Logic does not seem correct here. Can they both be 'falsey'?
> >
> > I'm probably ignorant to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable?
>
> Joe Smith wrote:
> In theory, this is to represent xor (you specify at least a file of hosts or a string of hosts, but not both).
>
> This was to convert None/"" to False and "filename_or_hosts" to True, but would be happy to move to something else.
>
> Bill Farner wrote:
> Ah, yes — the double negative fooled me.
>
> how about instead the more direct:
>
> if bool(x) == bool(y):
> die(..)
http://writing.phillipmartin.info/la_double_negative.gif
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32069
-----------------------------------------------------------
On Jan. 16, 2014, 11:59 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 11:59 a.m.)
>
>
> Review request for Aurora and Jonathan Boulle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 16, 2014, 8:36 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 38
> > <https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38>
> >
> > Logic does not seem correct here. Can they both be 'falsey'?
> >
> > I'm probably ignorant to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable?
>
> Joe Smith wrote:
> In theory, this is to represent xor (you specify at least a file of hosts or a string of hosts, but not both).
>
> This was to convert None/"" to False and "filename_or_hosts" to True, but would be happy to move to something else.
Ah, yes — the double negative fooled me.
how about instead the more direct:
if bool(x) == bool(y):
die(..)
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32069
-----------------------------------------------------------
On Jan. 16, 2014, 7:59 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 7:59 p.m.)
>
>
> Review request for Aurora and Jonathan Boulle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Joe Smith <ya...@gmail.com>.
> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 38
> > <https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38>
> >
> > Logic does not seem correct here. Can they both be 'falsey'?
> >
> > I'm probably ignorant to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable?
In theory, this is to represent xor (you specify at least a file of hosts or a string of hosts, but not both).
This was to convert None/"" to False and "filename_or_hosts" to True, but would be happy to move to something else.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32069
-----------------------------------------------------------
On Jan. 16, 2014, 11:59 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 11:59 a.m.)
>
>
> Review request for Aurora and Jonathan Boulle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 16983: Fix maintenance command documentation and
host/filename logic.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32069
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/admin.py
<https://reviews.apache.org/r/16983/#comment60766>
Logic does not seem correct here. Can they both be 'falsey'?
I'm probably ignorant to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable?
- Bill Farner
On Jan. 16, 2014, 7:59 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 7:59 p.m.)
>
>
> Review request for Aurora and Jonathan Boulle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix maintenance command documentation and host/filename logic.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf
>
> Diff: https://reviews.apache.org/r/16983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Smith
>
>