You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "PeterRK (via GitHub)" <gi...@apache.org> on 2024/04/20 13:14:40 UTC
[PR] fail at field type mismatch in json2pb (brpc)
PeterRK opened a new pull request, #2608:
URL: https://github.com/apache/brpc/pull/2608
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
json2pb中遇到字段类型不匹配时的处理方式由跳过改为报错，以避免引发后续隐藏错误。
Side effects:
- Performance effects(性能影响):
无
- Breaking backward compatibility(向后兼容性):
对一种此前被忽略的错误会报出
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fail at field type mismatch in json2pb (brpc)
Posted by "PeterRK (via GitHub)" <gi...@apache.org>.
PeterRK commented on PR #2608:
URL: https://github.com/apache/brpc/pull/2608#issuecomment-2072326140
> 提供一个option来支持该特性，是不是合适些？这样就不会影响已有的逻辑了。
这应该是一个bug，原来的实现中string、bool、int32、uint32四种类型没有返回错误，int64、uint64、float、double、enum、object则会返回错误。统一都返回错误才是合理的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fail at field type mismatch in json2pb (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #2608:
URL: https://github.com/apache/brpc/pull/2608#issuecomment-2067680943
提供一个option来支持该特性，是不是合适些？这样就不会影响已有的逻辑了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fail at field type mismatch in json2pb (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #2608:
URL: https://github.com/apache/brpc/pull/2608#issuecomment-2067680476
补充一下UT吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fail at field type mismatch in json2pb (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #2608:
URL: https://github.com/apache/brpc/pull/2608#issuecomment-2071847659
master分支已经修复了ci的问题，可以更新一下PR。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fail at field type mismatch in json2pb (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2608:
URL: https://github.com/apache/brpc/pull/2608#issuecomment-2068354259
> 提供一个option来支持该特性，是不是合适些？这样就不会影响已有的逻辑了。
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org