You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 23:27:16 UTC
[GitHub] [airflow] kaxil opened a new pull request #13471: Remove thrift as a core dependency
kaxil opened a new pull request #13471:
URL: https://github.com/apache/airflow/pull/13471
`thrift` is a dependency for Apache Hive and it is not required by Core Airflow:
```
airflow/providers/apache/hive/hooks/hive.py:489: # This is for pickling to work despite the thrift hive client not
airflow/providers/apache/hive/hooks/hive.py:500: """Returns a Hive thrift client."""
airflow/providers/apache/hive/hooks/hive.py:502: from thrift.protocol import TBinaryProtocol
airflow/providers/apache/hive/hooks/hive.py:503: from thrift.transport import TSocket, TTransport
airflow/providers/apache/hive/hooks/hive.py:531: from thrift_sasl import TSaslClientTransport
airflow/providers/apache/hive/sensors/hive_partition.py:41: :param metastore_conn_id: reference to the metastore thrift service
airflow/providers/apache/hive/sensors/metastore_partition.py:28: queries generated by the Metastore thrift service when hitting
airflow/providers/apache/hive/sensors/named_hive_partition.py:36: :param metastore_conn_id: reference to the metastore thrift service
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-754300617
[The Workflow run](https://github.com/apache/airflow/actions/runs/462235709) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-754292875
Test failure is unrelated -- Master is broken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-756105327
> Except in this case we haven't actually removed the dep, at least not what is installed via the extras ;)
True. I just prefer to be cautious and do it always. The way how PIP treats `install requires` when doing eager dependency update (so after it gets merged) might work in unexpected ways - depending if thrift is pre-installed before or not.
But yeah, probably in this case there are no scenarios where it would hurt us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13471:
URL: https://github.com/apache/airflow/pull/13471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-756082622
> When we remove (and only when you remove) anything from the list here, we should increase PIP_DEPENDENCIES_EPOCH_NUMBER approproately. I updated the outdated description in in #13409 and we should update increase the PIP_DEPENDENCIES_EPOCH_NUMBER number to point to both Dockerfile and Dockerfile.ci and to the right name. Let's merge #13409 first and then we can rebase on top of it, change the EPOCH and get it removed.
Except in this case we haven't actually removed the dep, at least not what is installed via the extras ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-756105869
It's OK for me. Just do it on your own risk ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13471: Remove thrift as a core dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-754464301
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org