You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/13 02:58:45 UTC
[GitHub] [beam] allenpradeep opened a new pull request #13990: [BEAM-11805] Replace user-agent for spanner
allenpradeep opened a new pull request #13990:
URL: https://github.com/apache/beam/pull/13990
This patch contains the workaround to replace the user-agent for spanner.
R: @TheNeuralBit @nielm
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nielm commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
nielm commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-778577449
> @TheNeuralBit - This patch has the following checkstyle violation. Can you help with this?
> [ant:checkstyle] [ERROR] /usr/local/google/home/alxavier/spannerio/apbeam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:35: You are using raw guava, please use vendored guava classes. [ForbidNonVendoredGuava]
Replace the import
com.google.common.util.concurrent.ThreadFactoryBuilder
With
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.util.concurrent.ThreadFactoryBuilder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780755991
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (a88a034) into [master](https://codecov.io/gh/apache/beam/commit/8f879571efa811a30849ba9dfeb3ef953637fbe1?el=desc) (8f87957) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 469 469
Lines 58343 58343
=======================================
+ Hits 48394 48395 +1
+ Misses 9949 9948 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [8f87957...a88a034](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-778869353
@nielm @thiagotnunes - Thanks
Please take a look.
I have fixed the checkstyle issues and added the support for checking emulator connection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #13990:
URL: https://github.com/apache/beam/pull/13990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (a88a034) into [master](https://codecov.io/gh/apache/beam/commit/8f879571efa811a30849ba9dfeb3ef953637fbe1?el=desc) (8f87957) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 469 469
Lines 58343 58343
=======================================
+ Hits 48394 48395 +1
+ Misses 9949 9948 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [8f87957...a88a034](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780255833
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (a88a034) into [master](https://codecov.io/gh/apache/beam/commit/8f879571efa811a30849ba9dfeb3ef953637fbe1?el=desc) (8f87957) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 469 469
Lines 58343 58343
=======================================
+ Hits 48394 48395 +1
+ Misses 9949 9948 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [8f87957...a88a034](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577870524
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +189,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(getEndpoint(host.get()));
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
Review comment:
Ah I see, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577270669
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +189,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(getEndpoint(host.get()));
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
Review comment:
This is to enable a fail fast if the emulator is not running, but the user has set the emulator host environment variable.
As per [function-checkEmulatorConnection](https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L497-L539) [line 502](https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L502), the fail fast link works only if the channelprovider is set to null. This workaround only sets the channel provider only when we are not going to connect to emulator.
cc @thiagotnunes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (a88a034) into [master](https://codecov.io/gh/apache/beam/commit/8f879571efa811a30849ba9dfeb3ef953637fbe1?el=desc) (8f87957) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 469 469
Lines 58343 58343
=======================================
+ Hits 48394 48395 +1
+ Misses 9949 9948 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [8f87957...a88a034](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577267568
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +189,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(getEndpoint(host.get()));
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
Review comment:
Why add an `else` here? The previous logic called `setHeaderProvider` unconditionally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780898542
Failure is a flake in FhirIOReadIT. I'll go ahead and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] thiagotnunes commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577263467
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +187,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(host.get());
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
+ String userAgentString = USER_AGENT_PREFIX + "/" + ReleaseInfo.getReleaseInfo().getVersion();
+ /* Workaround to setup user-agent string.
+ * InstantiatingGrpcChannelProvider will override the settings provided.
+ * The section below and all associated artifacts will be removed once the bug
+ * that prevents setting user-agent is fixed.
+ * https://github.com/googleapis/java-spanner/pull/747
Review comment:
- https://github.com/googleapis/java-spanner/pull/747 is the PR where the bug was introduced.
- https://github.com/googleapis/java-spanner/issues/880 is the issue.
- https://github.com/googleapis/java-spanner/pull/871 is the PR for the bug fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-778869143
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-778551937
@TheNeuralBit - This patch has the following checkstyle violation. Can you help with this?
[ant:checkstyle] [ERROR] /usr/local/google/home/alxavier/spannerio/apbeam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:35: You are using raw guava, please use vendored guava classes. [ForbidNonVendoredGuava]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780764975
@allenpradeep The merge conflict looks to be due to https://github.com/apache/beam/pull/13804, which upgraded guava. I don't think it's an actual conflict, it's just that 007c0ab is upgrading gRPC, which is on an adjacent line. The resolution should be to just make sure we upgrade both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
suztomo commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577269240
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +187,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(host.get());
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
+ String userAgentString = USER_AGENT_PREFIX + "/" + ReleaseInfo.getReleaseInfo().getVersion();
+ /* Workaround to setup user-agent string.
+ * InstantiatingGrpcChannelProvider will override the settings provided.
+ * The section below and all associated artifacts will be removed once the bug
+ * that prevents setting user-agent is fixed.
+ * https://github.com/googleapis/java-spanner/pull/747
Review comment:
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780236381
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780255739
> @allenpradeep could you also cherry-pick the the version update commits from #13765? They were rolled back in #13792. I'd like to apply both changes at once to make sure they pass CI before merging.
@TheNeuralBit - cherry-picked the the 2 commits from #13765.
Waiting for the tests to complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780774680
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/8f879571efa811a30849ba9dfeb3ef953637fbe1?el=desc) (8f87957) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.94% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
+ Hits 48394 48396 +2
+ Misses 9949 9947 -2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `87.50% <0.00%> (+1.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [8f87957...a88a034](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (a88a034) into [master](https://codecov.io/gh/apache/beam/commit/8f879571efa811a30849ba9dfeb3ef953637fbe1?el=desc) (8f87957) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 469 469
Lines 58343 58343
=======================================
+ Hits 48394 48395 +1
+ Misses 9949 9948 -1
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `96.49% <0.00%> (-1.76%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (+0.15%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13990/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [8f87957...a88a034](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577266282
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +187,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(host.get());
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
+ String userAgentString = USER_AGENT_PREFIX + "/" + ReleaseInfo.getReleaseInfo().getVersion();
+ /* Workaround to setup user-agent string.
+ * InstantiatingGrpcChannelProvider will override the settings provided.
+ * The section below and all associated artifacts will be removed once the bug
+ * that prevents setting user-agent is fixed.
+ * https://github.com/googleapis/java-spanner/pull/747
Review comment:
Added https://github.com/googleapis/java-spanner/pull/871 in the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780774503
> @allenpradeep The merge conflict looks to be due to #13804, which upgraded guava. I don't think it's an actual conflict, it's just that [007c0ab](https://github.com/apache/beam/commit/007c0ab955b73962c5188412b446f2bec0408cc7) is upgrading gRPC, which is on an adjacent line. The resolution should be to just make sure we upgrade both.
@TheNeuralBit
Done. PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780237668
> @allenpradeep could you also cherry-pick the the version update commits from #13765? They were rolled back in #13792. I'd like to apply both changes at once to make sure they pass CI before merging.
There were some spanner test issues with the previous commit. I'll cherry pick #13765 after the integration tests passes and resend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on a change in pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
suztomo commented on a change in pull request #13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577131428
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +187,34 @@ private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(host.get());
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
+ String userAgentString = USER_AGENT_PREFIX + "/" + ReleaseInfo.getReleaseInfo().getVersion();
+ /* Workaround to setup user-agent string.
+ * InstantiatingGrpcChannelProvider will override the settings provided.
+ * The section below and all associated artifacts will be removed once the bug
+ * that prevents setting user-agent is fixed.
+ * https://github.com/googleapis/java-spanner/pull/747
Review comment:
Is this a link to a bug to be fixed (I see it's been merged already)?
If not, would you also add the link to the bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780261509
# [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=h1) Report
> Merging [#13990](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=desc) (e8cb006) into [master](https://codecov.io/gh/apache/beam/commit/c8cc2a3217fe98b3effc7aa716ddccfbb094084e?el=desc) (c8cc2a3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13990 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 469 469
Lines 58343 58343
=======================================
Hits 48396 48396
Misses 9947 9947
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=footer). Last update [edeaf67...e8cb006](https://codecov.io/gh/apache/beam/pull/13990?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13990: [BEAM-11805] Replace user-agent for spanner
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13990:
URL: https://github.com/apache/beam/pull/13990#issuecomment-780703126
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org