You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Jirsa (JIRA)" <ji...@apache.org> on 2017/03/28 19:02:41 UTC

[jira] [Comment Edited] (CASSANDRA-13384) Legacy caching options can prevent 3.0 upgrade

    [ https://issues.apache.org/jira/browse/CASSANDRA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945738#comment-15945738 ] 

Jeff Jirsa edited comment on CASSANDRA-13384 at 3/28/17 7:02 PM:
-----------------------------------------------------------------

Note: 3.11 seems to have made {{testReport/junit/org.apache.cassandra.schema/LegacySchemaMigratorTest}} flakey

{code}
    [junit] Testcase: testMigrateLegacyCachingOptions(org.apache.cassandra.schema.LegacySchemaMigratorTest):	FAILED
    [junit] This assertion failure is probably due to accessing Schema.instance from client-mode tools - See CASSANDRA-8143.
    [junit] junit.framework.AssertionFailedError: This assertion failure is probably due to accessing Schema.instance from client-mode tools - See CASSANDRA-8143.
    [junit] 	at org.apache.cassandra.config.CFMetaData.<init>(CFMetaData.java:286)
    [junit] 	at org.apache.cassandra.config.CFMetaData.<init>(CFMetaData.java:65)
    [junit] 	at org.apache.cassandra.config.CFMetaData$Builder.build(CFMetaData.java:1328)
    [junit] 	at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:427)
    [junit] 	at org.apache.cassandra.db.SystemKeyspace.compile(SystemKeyspace.java:435)
    [junit] 	at org.apache.cassandra.db.SystemKeyspace.<clinit>(SystemKeyspace.java:116)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigrator.<clinit>(LegacySchemaMigrator.java:65)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.testMigrateLegacyCachingOptions(LegacySchemaMigratorTest.java:106)
    [junit]
    [junit]
    [junit] Testcase: testMigrate(org.apache.cassandra.schema.LegacySchemaMigratorTest):	Caused an ERROR
    [junit] Could not initialize class org.apache.cassandra.db.SystemKeyspace
    [junit] java.lang.NoClassDefFoundError: Could not initialize class org.apache.cassandra.db.SystemKeyspace
    [junit] 	at org.apache.cassandra.config.Schema.<init>(Schema.java:70)
    [junit] 	at org.apache.cassandra.config.Schema.<clinit>(Schema.java:49)
    [junit] 	at org.apache.cassandra.cql3.functions.UDFunction.<init>(UDFunction.java:215)
    [junit] 	at org.apache.cassandra.cql3.functions.JavaBasedUDFunction.<init>(JavaBasedUDFunction.java:190)
    [junit] 	at org.apache.cassandra.cql3.functions.UDFunction.create(UDFunction.java:233)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.keyspaceWithUDFs(LegacySchemaMigratorTest.java:374)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.keyspacesToMigrate(LegacySchemaMigratorTest.java:293)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.testMigrate(LegacySchemaMigratorTest.java:72)
    [junit]
{code}

Investigating to see if it's a test problem or regression.



was (Author: jjirsa):
Note: 3.11 seems to have made {{testReport/junit/org.apache.cassandra.schema/LegacySchemaMigratorTest}} flakey

{code}
    [junit] Testcase: testMigrateLegacyCachingOptions(org.apache.cassandra.schema.LegacySchemaMigratorTest):	FAILED
    [junit] This assertion failure is probably due to accessing Schema.instance from client-mode tools - See CASSANDRA-8143.
    [junit] junit.framework.AssertionFailedError: This assertion failure is probably due to accessing Schema.instance from client-mode tools - See CASSANDRA-8143.
    [junit] 	at org.apache.cassandra.config.CFMetaData.<init>(CFMetaData.java:286)
    [junit] 	at org.apache.cassandra.config.CFMetaData.<init>(CFMetaData.java:65)
    [junit] 	at org.apache.cassandra.config.CFMetaData$Builder.build(CFMetaData.java:1328)
    [junit] 	at org.apache.cassandra.config.CFMetaData.compile(CFMetaData.java:427)
    [junit] 	at org.apache.cassandra.db.SystemKeyspace.compile(SystemKeyspace.java:435)
    [junit] 	at org.apache.cassandra.db.SystemKeyspace.<clinit>(SystemKeyspace.java:116)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigrator.<clinit>(LegacySchemaMigrator.java:65)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.testMigrateLegacyCachingOptions(LegacySchemaMigratorTest.java:106)
    [junit]
    [junit]
    [junit] Testcase: testMigrate(org.apache.cassandra.schema.LegacySchemaMigratorTest):	Caused an ERROR
    [junit] Could not initialize class org.apache.cassandra.db.SystemKeyspace
    [junit] java.lang.NoClassDefFoundError: Could not initialize class org.apache.cassandra.db.SystemKeyspace
    [junit] 	at org.apache.cassandra.config.Schema.<init>(Schema.java:70)
    [junit] 	at org.apache.cassandra.config.Schema.<clinit>(Schema.java:49)
    [junit] 	at org.apache.cassandra.cql3.functions.UDFunction.<init>(UDFunction.java:215)
    [junit] 	at org.apache.cassandra.cql3.functions.JavaBasedUDFunction.<init>(JavaBasedUDFunction.java:190)
    [junit] 	at org.apache.cassandra.cql3.functions.UDFunction.create(UDFunction.java:233)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.keyspaceWithUDFs(LegacySchemaMigratorTest.java:374)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.keyspacesToMigrate(LegacySchemaMigratorTest.java:293)
    [junit] 	at org.apache.cassandra.schema.LegacySchemaMigratorTest.testMigrate(LegacySchemaMigratorTest.java:72)
    [junit]
{code}

Not merging until I understand if it's a test problem or regression.


> Legacy caching options can prevent 3.0 upgrade
> ----------------------------------------------
>
>                 Key: CASSANDRA-13384
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13384
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Schema
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Minor
>             Fix For: 3.0.x, 3.11.x
>
>
> In 2.1, we wrote caching options as a JSONified map, but we tolerated raw strings ["ALL", "KEYS_ONLY", "ROWS_ONLY", and "NONE"|https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/cache/CachingOptions.java#L42].
> If a 2.1 node with any of these strings is upgraded to 3.0, the legacy schema migration will fail.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)