You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "QiuYucheng2003 (via GitHub)" <gi...@apache.org> on 2026/01/12 07:31:21 UTC
[I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
QiuYucheng2003 opened a new issue, #15031:
URL: https://github.com/apache/iceberg/issues/15031
### Apache Iceberg version
main (development)
### Query engine
None
### Please describe the bug 🐞
### Context
The `org.apache.iceberg.util.ThreadPools` class maintains static `ExecutorService` instances (`WORKER_POOL` and `DELETE_WORKER_POOL`) that are initialized statically and persist for the lifetime of the JVM.
### Problem
These thread pools are created using `MoreExecutors.getExitingExecutorService`, which registers a **JVM shutdown hook** to terminate the threads. However, there is no public API to explicitly shut down these pools when the Iceberg library is unloaded or when the application using Iceberg is stopped (without killing the JVM).
### Impact
In environments that support hot-reloading or dynamic lifecycles (e.g., Tomcat Web Containers, Flink clusters, OSGi), the JVM does not exit when an application is undeployed.
1. The static thread pools remain active.
2. The threads inside these pools retain references to their `inheritedAccessControlContext` or `contextClassLoader`.
3. This prevents the application's `ClassLoader` from being garbage collected.
4. Repeated redeployments lead to a **ClassLoader Leak** and eventually `java.lang.OutOfMemoryError: Metaspace`.
### Analysis from Source Code
In `ThreadPools.java`:
```java
private static final ExecutorService WORKER_POOL =
newExitingWorkerPool("iceberg-worker-pool", WORKER_THREAD_POOL_SIZE);
The WORKER_POOL is private static final and depends solely on SystemConfigs. There is no mechanism to release these resources programmatically.
### Willingness to contribute
- [x] I can contribute a fix for this bug independently
- [ ] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
- [ ] I cannot contribute a fix for this bug at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "osscm (via GitHub)" <gi...@apache.org>.
osscm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3982714634
@mxm please check this PR https://github.com/apache/iceberg/pull/15492
cc @svalaskevicius
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3767387346
Let's go with option (1) then, which is to track all created static thread pools and allow shutting them down via a new static method, e.g. `ThreadPools#shutdownAll()`. We can call that method from the `close()` methods of the Flink Iceberg operators. This method will be called at the very end of the lifecycle of a Flink job. At that stage, no more processing will take place and all side effects have already been committed.
>If we agrees on Option1, can send a PR.
That sounds great. I'd be happy to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #15031: Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios
URL: https://github.com/apache/iceberg/issues/15031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "QiuYucheng2003 (via GitHub)" <gi...@apache.org>.
QiuYucheng2003 commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3738211786
Hi@pvary, thank you for the detailed analysis and suggestions!
I completely agree with your approach. Replacing the newExitingWorkerPool with standard thread pools and managing their lifecycle explicitly in the close() methods seems to be the correct way to resolve the ClassLoader leak.
Unfortunately, I don't have the bandwidth to contribute this fix at the moment. However, since the solution path is now very clear, I hope this discussion helps anyone else who might want to pick this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3751097034
We should probably figure something out use cases like this to shut down the threadpool ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "svalaskevicius (via GitHub)" <gi...@apache.org>.
svalaskevicius commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3892103440
an alternative option, that should work for both cases:
would there be a way to inject/register a custom "make it an exiting threadpool" strategy? i.e. a function `ThreadPoolExecutor => ExecutorService`
The default value would do the same thing: `return MoreExecutors.getExitingExecutorService(input)`.
In flink's case, it would be possible to register a service that collects threadpools and has a manual shutdown() operation, this way giving the control and also not leaving shutdown hooks hanging about..
in my case I'd probably do the same (!!), as I know when it is safe to call the shutdown.
it should work, if we make it a separate class - and register the custom static strategy _before_ the `ThreadPool` class is invoked. although I don't quite like the fact of the static-ness here... any thoughts?
I'd be happy to try to come up with something suitable code-wise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-6006474649
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3743123485
Thanks for raising the issue @QiuYucheng2003! Just adding a bit more Flink context to what's already been observed.
Flink has two distinct deployment modes:
1. Application clusters - only spun up for one particular job and shut down when the job completes / gets canceled.
2. Session clusters - long-lived clusters, which can host any number of jobs.
Flink recycles the classloader within a given job, even when the job restarts. So we should not see this problem in application clusters because there will only ever be one job. Session clusters, on the other hand, create a new classloader for every job and hence accumulate thread pools across these jobs, until the cluster gets shut down.
Generally, using static variables which reference user classes is strongly discouraged for Flink session clusters. It looks like we need an explicit shutdown call which we can run when Flink jobs terminate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3759814920
> I think the best we can do is to (1) add a shutdown method for ThreadPools
We have some static pools in the `ThreadPools`, but `ThreadPools.newExitingWorkerPool` is used in 4 other places where it is used in static context, which has the exact same issue. Maybe we can create a variable which tracks the pools created by the `newExitingWorkerPool` method, and create a static method in `ThreadPools` which shuts down all of these pools.
> Alternatively, it could work to start a daemon alongside with the static ThreadPools
I don't like this solution because of the mentioned drawbacks
> Finally, I wonder whether depending on static thread pools in Iceberg is a sound design pattern. We could at least add a way to disable creating them in a static way, such that methods like ThreadPools.getWorkerPool() can optionally return new thread pools which are managed by the user.
It is possible to use the `ThreadPools.newFixedThreadPool` if we decide to do so. My understanding is that these use-cases specifically want a shareable, reusable worker pool which "globally" limit the number of threads for specific cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "svalaskevicius (via GitHub)" <gi...@apache.org>.
svalaskevicius commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3892122734
extending on the above idea, we could have the standard factory to collect and manage the shutdown call, instead of using `MoreExecutors`.
we could expose:
- manual shutdown of all pools started so far
- automatic shutdown
- ability to _opt out_ of the automatic shutdown
- ...?
it seems this should be quite simple to implement....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "osscm (via GitHub)" <gi...@apache.org>.
osscm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3740350346
+1 to @RussellSpitzer's question.
In systems like Tomcat or OSGi, applications are loaded and unloaded using different classloaders, so libraries are generally expected to clean up resources when an app is stopped.
From a quick look at Flink (not a Flink expert), it seems Flink does something similar in session clusters. Different jobs run with their own classloaders, and Flink can unload them without restarting the JVM. This works fine as long as there are no running threads or other references that keep the classloader alive.
This looks related to:
https://github.com/apache/iceberg/issues/13058
— where threads kept growing unless Flink was restarted
https://github.com/apache/iceberg/issues/12220
— about thread pools that rely on JVM shutdown hooks
In a long-running Flink session cluster, the JVM usually does not restart when jobs stop. So relying only on JVM shutdown hooks to clean up thread pools may not be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3738993121
So does Flink have this issue right now? Basically there is a JVM framework which loads and unloads an application with the Iceberg library, and each time the classloader is dropped and a new one is made we lose the old static pool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "osscm (via GitHub)" <gi...@apache.org>.
osscm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3937939027
@mxm @svalaskevicius sorry I got stuck with some work... I got a PR getting internal approval will raise by this weekend...
I took a slight different way, we can see if that approach looks ok...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3750670595
Flink has lifecycle methods on its operators which get executed on job shutdown, e.g. close(), but no way to register hooks. If we had such a hook on each worker node, we could clear the worker pool static reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "svalaskevicius (via GitHub)" <gi...@apache.org>.
svalaskevicius commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3885547060
hi, I have an opposite problem where the dynamic / injectable threadpool would help:
_we still need the library to commit the changes to AWS - before exiting_, but the static shutdown hook shuts the threadpool down before this can be done.
I was about to create a separate issue for it but given this is very related to the scope of this problem I hope it can be discussed together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3759257687
Session clusters are not the primary deployment model for Flink/Iceberg, but I agree we should address this issue.
In the absence of a job shutdown hook, I think the best we can do is to (1) add a shutdown method for ThreadPools, (2) call that method from the Flink Iceberg source / sink on job shutdown. This is a bit fragile and best-effort, but it should work.
Alternatively, it could work to start a daemon alongside with the static ThreadPools, which periodically checks whether the associated classloader has already been closed. If it has, it would shut down the thread pools and exit. The drawback of this approach is that Java doesn't directly expose a way to check for closed Classloaders because not all of them are. Flink's URLClassLoader is closable, so with some Java magic it is doable.
Finally, I wonder whether depending on static thread pools in Iceberg is a sound design pattern. We could at least add a way to disable creating them in a static way, such that methods like `ThreadPools.getWorkerPool()` can optionally return new thread pools which are managed by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "osscm (via GitHub)" <gi...@apache.org>.
osscm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3764189084
>> I think the best we can do is to (1) add a shutdown method for ThreadPools
> We have some static pools in the ThreadPools, but ThreadPools.newExitingWorkerPool is used in 4 other places where it is used in static context, which has the exact same issue. Maybe we can create a variable which tracks the pools created by the newExitingWorkerPool method, and create a static method in ThreadPools which shuts down all of these pools.
Option1 - This seems to be a safer and feasible option.
> Finally, I wonder whether depending on static thread pools in Iceberg is a sound design pattern. We could at least add a way to disable creating them in a static way, such that methods like ThreadPools.getWorkerPool() can optionally return new thread pools which are managed by the user.
>> It is possible to use the ThreadPools.newFixedThreadPool if we decide to do so. My understanding is that these use-cases specifically want a shareable, reusable worker pool which "globally" limit the number of threads for specific cases.
+ 1
Option2 - Creating a new thread-pool for based on a flag is also a safer option, but can start creating threads which are not controlled by Iceberg, and rely on the client app to control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3743760789
> Generally, using static variables which reference user classes is strongly discouraged for Flink session clusters. It looks like we need an explicit shutdown call which we can run when Flink jobs terminate.
Is there a mechanism in Flink to register a hook that runs when a job terminates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3737843347
@QiuYucheng2003: Could we just replace the `newExitingWorkerPool` with `newFixedThreadPool` wherever we have `close` method, like `S3FileIO`, `HadoopFileIO`, `RESTMetricsReporter`, `AuthSessionCache`, and use `ThreadPools.getWorkerPool().shutdown()` and `ThreadPools.getDeleteWorkerPool().shutdown()` for shutting down our other pools. Maybe we could create a util method for the later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-4126800400
@RussellSpitzer The fix is ready here, also approved by Peter: https://github.com/apache/iceberg/pull/15312
@osscm We can evaluate your fix independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3890667407
That sounds more like a graceful shutdown issue. Once we have control over the shutdown hook, we add an option to wait for certain actions to finish before the shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3897387679
Hey @svalaskevicius! I've took a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "svalaskevicius (via GitHub)" <gi...@apache.org>.
svalaskevicius commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-3896379911
hi, please can you review #15312 ?
I've not tested it yet (in progress), but the idea should be visible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Core: Static thread pools in ThreadPools.java cause ClassLoader leaks in hot-reload scenarios [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #15031:
URL: https://github.com/apache/iceberg/issues/15031#issuecomment-5769497669
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org