[GitHub] [hive] pvary commented on a change in pull request #1134: HIVE-23703: Major QB compaction with multiple FileSinkOperators results in data loss and one original file

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1134:
URL: https://github.com/apache/hive/pull/1134#discussion_r441382235



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java
##########
@@ -113,7 +116,11 @@ private void processKeyValuePairs(Object key, Object value)
 
       // store the orc configuration from the first file. All other files should
       // match this configuration before merging else will not be merged
-      if (outWriter == null) {
+      int bucketId = 0;
+      if (conf.getIsCompactionTable()) {

Review comment:
       Can we do this outside the process loop? Maybe saving some time, since this part of the code runs for every item, and this can cause performance degradation (I guess)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org