You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/08/26 02:27:08 UTC
Review Request 37781: GEODE-139 Fixing
RebalanceOperationDUnitTest.testWaitFor* methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37781/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
The issue is that a previous test method was polluting the system. There
is a test of redundancy zones that sets the redundancy zone in 4 members
and disconnects the distributed system in all of those members at the
end.
However, there is a 5th member, the controller VM, that still has a
distributed system. It never had a redundancy zone set but it still
flipped a bit to indicate that redundancy zones should be enforced. From
that point on we refused to satisfy redundancy.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java 819bf9e1df3ca2018e46577185b14db4fec2a2a0
Diff: https://reviews.apache.org/r/37781/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 37781: GEODE-139 Fixing
RebalanceOperationDUnitTest.testWaitFor* methods
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37781/#review96534
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Aug. 25, 2015, 5:27 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37781/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 5:27 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The issue is that a previous test method was polluting the system. There
> is a test of redundancy zones that sets the redundancy zone in 4 members
> and disconnects the distributed system in all of those members at the
> end.
>
> However, there is a 5th member, the controller VM, that still has a
> distributed system. It never had a redundancy zone set but it still
> flipped a bit to indicate that redundancy zones should be enforced. From
> that point on we refused to satisfy redundancy.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java 819bf9e1df3ca2018e46577185b14db4fec2a2a0
>
> Diff: https://reviews.apache.org/r/37781/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>