You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Baodi Shi <ba...@apache.org> on 2023/07/14 10:07:40 UTC

[DISCUSS] PIP-281: Add notifyError method on PushSource

Hi, All

I opened a new PIP design PR.
I am looking forward to your feedback.

https://github.com/apache/pulsar/pull/20807
<https://github.com/apache/pulsar/pull/20776>



This is a very simple change and is forward-compatible. Sorry, I didn't
notice that this change required PIP before, so the related PRs have been
merged.

https://github.com/apache/pulsar/pull/20791

If this PIP vote does not pass, I revert this PR afterward.



Thanks,
Baodi Shi

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Posted by Zike Yang <zi...@apache.org>.

Thanks for the PIP. Looks good to me
+1 (non-binding)

Zike Yang

On Mon, Jul 17, 2023 at 9:05 AM PengHui Li <pe...@apache.org> wrote:
>
> Thanks,
>
> It looks good to me.
>
> Regards,
> Penghui
>
> On Sun, Jul 16, 2023 at 8:18 PM Baodi Shi <ba...@apache.org> wrote:
>
> > Hi, Penghui.
> >
> > Could you please help add a section to explain the compatibility guarantee?
> > > Others look good to me.
> >
> >
> > Added it, PTAL.
> >
> >
> > Thanks,
> > Baodi Shi
> >
> >
> > On Jul 14, 2023 at 18:27:34, PengHui Li <pe...@apache.org> wrote:
> >
> > > Could you please help add a section to explain the compatibility
> > guarantee?
> > > Others look good to me.
> > >
> > > Regards,
> > > Penghui
> > >
> > > On Fri, Jul 14, 2023 at 6:07 PM Baodi Shi <ba...@apache.org> wrote:
> > >
> > > Hi, All
> > >
> > >
> > > I opened a new PIP design PR.
> > >
> > > I am looking forward to your feedback.
> > >
> > >
> > > https://github.com/apache/pulsar/pull/20807
> > >
> > > <https://github.com/apache/pulsar/pull/20776>
> > >
> > >
> > >
> > >
> > > This is a very simple change and is forward-compatible. Sorry, I didn't
> > >
> > > notice that this change required PIP before, so the related PRs have been
> > >
> > > merged.
> > >
> > >
> > > https://github.com/apache/pulsar/pull/20791
> > >
> > >
> > > If this PIP vote does not pass, I revert this PR afterward.
> > >
> > >
> > >
> > >
> > > Thanks,
> > >
> > > Baodi Shi
> > >
> > >
> > >
> >

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Posted by PengHui Li <pe...@apache.org>.

Thanks,

It looks good to me.

Regards,
Penghui

On Sun, Jul 16, 2023 at 8:18 PM Baodi Shi <ba...@apache.org> wrote:

> Hi, Penghui.
>
> Could you please help add a section to explain the compatibility guarantee?
> > Others look good to me.
>
>
> Added it, PTAL.
>
>
> Thanks,
> Baodi Shi
>
>
> On Jul 14, 2023 at 18:27:34, PengHui Li <pe...@apache.org> wrote:
>
> > Could you please help add a section to explain the compatibility
> guarantee?
> > Others look good to me.
> >
> > Regards,
> > Penghui
> >
> > On Fri, Jul 14, 2023 at 6:07 PM Baodi Shi <ba...@apache.org> wrote:
> >
> > Hi, All
> >
> >
> > I opened a new PIP design PR.
> >
> > I am looking forward to your feedback.
> >
> >
> > https://github.com/apache/pulsar/pull/20807
> >
> > <https://github.com/apache/pulsar/pull/20776>
> >
> >
> >
> >
> > This is a very simple change and is forward-compatible. Sorry, I didn't
> >
> > notice that this change required PIP before, so the related PRs have been
> >
> > merged.
> >
> >
> > https://github.com/apache/pulsar/pull/20791
> >
> >
> > If this PIP vote does not pass, I revert this PR afterward.
> >
> >
> >
> >
> > Thanks,
> >
> > Baodi Shi
> >
> >
> >
>

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Posted by Baodi Shi <ba...@apache.org>.

Hi, Penghui.

Could you please help add a section to explain the compatibility guarantee?
> Others look good to me.


Added it, PTAL.


Thanks,
Baodi Shi


On Jul 14, 2023 at 18:27:34, PengHui Li <pe...@apache.org> wrote:

> Could you please help add a section to explain the compatibility guarantee?
> Others look good to me.
>
> Regards,
> Penghui
>
> On Fri, Jul 14, 2023 at 6:07 PM Baodi Shi <ba...@apache.org> wrote:
>
> Hi, All
>
>
> I opened a new PIP design PR.
>
> I am looking forward to your feedback.
>
>
> https://github.com/apache/pulsar/pull/20807
>
> <https://github.com/apache/pulsar/pull/20776>
>
>
>
>
> This is a very simple change and is forward-compatible. Sorry, I didn't
>
> notice that this change required PIP before, so the related PRs have been
>
> merged.
>
>
> https://github.com/apache/pulsar/pull/20791
>
>
> If this PIP vote does not pass, I revert this PR afterward.
>
>
>
>
> Thanks,
>
> Baodi Shi
>
>
>

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Posted by PengHui Li <pe...@apache.org>.

Could you please help add a section to explain the compatibility guarantee?
Others look good to me.

Regards,
Penghui

On Fri, Jul 14, 2023 at 6:07 PM Baodi Shi <ba...@apache.org> wrote:

> Hi, All
>
> I opened a new PIP design PR.
> I am looking forward to your feedback.
>
> https://github.com/apache/pulsar/pull/20807
> <https://github.com/apache/pulsar/pull/20776>
>
>
>
> This is a very simple change and is forward-compatible. Sorry, I didn't
> notice that this change required PIP before, so the related PRs have been
> merged.
>
> https://github.com/apache/pulsar/pull/20791
>
> If this PIP vote does not pass, I revert this PR afterward.
>
>
>
> Thanks,
> Baodi Shi
>