You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/12 12:57:44 UTC
[GitHub] [flink] kl0u opened a new pull request #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
kl0u opened a new pull request #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835
## What is the purpose of the change
Before the introduction of the executor (FLIP-73) and the consolidation of the different environments, some environments were overwriting the parallelism setting in their constructor. Now, after the refactoring of the environments we were not always doing it. In addition, the problem now is even more evident as that the user can directly pass a `Configuration` in the `(Stream)ExecutionEnvironment` constructor.
This PR makes sure that we always expose a consistent view of the parallelism when the user calls `env.getParallelism()`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10835:
[FLINK-15533] Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#discussion_r365811483
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -272,6 +272,7 @@ public StreamExecutionEnvironment setMaxParallelism(int maxParallelism) {
* value.
*/
public int getParallelism() {
+ consolidateParallelismDefinitionsInConfiguration();
Review comment:
I think we should call this in the constructor, so that it is called at a well known location and not the just the first time `getParallelism()` is called. There is still some legacy weirdness around this setting, because the `ExecutionConfig` sets this to `PARALLELISM_DEFAULT` but this value is then never used. This is for legacy reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144175735 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144220641 TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4305 TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144175735) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302)
* 8925fc8edbdf729ec497f3a69d1faadfeb0c947c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144220641) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4305)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-574100546
Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144175735 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144175735) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144175735 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144175735) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302)
* 8925fc8edbdf729ec497f3a69d1faadfeb0c947c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144175735 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144220641 TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4305 TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144175735) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302)
* 8925fc8edbdf729ec497f3a69d1faadfeb0c947c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144220641) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4305)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144175735 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144175735) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-574097974
This looks good now, yes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u closed pull request #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #10835:
[FLINK-15533] Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#discussion_r365821297
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -272,6 +272,7 @@ public StreamExecutionEnvironment setMaxParallelism(int maxParallelism) {
* value.
*/
public int getParallelism() {
+ consolidateParallelismDefinitionsInConfiguration();
Review comment:
Thanks @aljoscha , I updated the PR. I think that your suggestion is correct as it respect the priority order of the different places where the user can specify the parallelism. Let's see what Travis has to say.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-574098379
Thanks a lot @aljoscha and @lirui-apache ! Merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10835: [FLINK-15533] Fix
parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573413065
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0590888514ff79680992bf39f72235a4d90bb75b (Sun Jan 12 13:00:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10835: [FLINK-15533]
Fix parallelism setting propagation during graph instantiation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10835: [FLINK-15533] Fix parallelism setting propagation during graph instantiation.
URL: https://github.com/apache/flink/pull/10835#issuecomment-573416112
<!--
Meta data
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144051170 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:0590888514ff79680992bf39f72235a4d90bb75b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269 TriggerType:PUSH TriggerID:0590888514ff79680992bf39f72235a4d90bb75b
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:40ecb0d1a992468d1a7ac2d9910633380e95a40e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163783 TriggerType:PUSH TriggerID:40ecb0d1a992468d1a7ac2d9910633380e95a40e
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144175735 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:83768e64350d021ffc276bc562d78cf41ab6d79b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302 TriggerType:PUSH TriggerID:83768e64350d021ffc276bc562d78cf41ab6d79b
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144220641 TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
Hash:8925fc8edbdf729ec497f3a69d1faadfeb0c947c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4305 TriggerType:PUSH TriggerID:8925fc8edbdf729ec497f3a69d1faadfeb0c947c
-->
## CI report:
* 0590888514ff79680992bf39f72235a4d90bb75b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144051170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4269)
* 40ecb0d1a992468d1a7ac2d9910633380e95a40e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163783) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4296)
* 83768e64350d021ffc276bc562d78cf41ab6d79b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144175735) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4302)
* 8925fc8edbdf729ec497f3a69d1faadfeb0c947c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144220641) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4305)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services