You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/02 18:40:56 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13417: refactor: add set data mask to build query
codecov[bot] commented on pull request #13417:
URL: https://github.com/apache/superset/pull/13417#issuecomment-789125837
# [Codecov](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=h1) Report
> Merging [#13417](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=desc) (af0052f) into [master](https://codecov.io/gh/apache/superset/commit/b04aebfa99be2815f5e9d9adeaf63f0b1b8ee17f?el=desc) (b04aebf) will **decrease** coverage by `4.18%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13417 +/- ##
==========================================
- Coverage 77.23% 73.04% -4.19%
==========================================
Files 900 599 -301
Lines 45601 21150 -24451
Branches 5415 5416 +1
==========================================
- Hits 35221 15450 -19771
+ Misses 10253 5573 -4680
Partials 127 127
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.95% <66.66%> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.75% <33.33%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `70.55% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.00% <66.66%> (-0.18%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | | |
| [superset/examples/css\_templates.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY3NzX3RlbXBsYXRlcy5weQ==) | | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | | |
| [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
| [superset/models/tags.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | | |
| [...uperset/databases/commands/importers/dispatcher.py](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | | |
| ... and [294 more](https://codecov.io/gh/apache/superset/pull/13417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=footer). Last update [b04aebf...9a525a3](https://codecov.io/gh/apache/superset/pull/13417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org