[GitHub] [logging-log4cxx] stephen-webb commented on issue #20: Windows build static library support

[GitBox <gi...@apache.org>]

stephen-webb commented on issue #20: Windows build static library support
URL: https://github.com/apache/logging-log4cxx/pull/20#issuecomment-596446458
 
 
   The PR may have picked up some other commits. I will look at it tomorrow.
   
   
   On Mon, Mar 9, 2020 at 7:04 PM Thorsten Schöning <no...@github.com>
   wrote:
   
   > *@ams-tschoening* requested changes on this pull request.
   >
   > If I reviewed correctly, there are multiple issues with this PR:
   >
   >    1.
   >
   >    it seems to reintroduce excluding tests, which I already removed in
   >    the past. Providing the missing binaries on Windows is easy and as many
   >    tests should be executed as possible in general. I won't merge excluding
   >    tests without any further discussion on why exactly you want those tests to
   >    be excluded. The binaries not being available by default in itself is not
   >    enough.
   >    2.
   >
   >    This PR seems to contain #19
   >    <https://github.com/apache/logging-log4cxx/pull/19> as well, for which
   >    I asked for additional changes on its own already. So please reduce this PR
   >    to what is really necessary for static library support itself only. Thanks!
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/logging-log4cxx/pull/20?email_source=notifications&email_token=ANLOSDVQVM4QOB2WDSYCPWTRGSPKBA5CNFSM4LEASJL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYOI7TI#pullrequestreview-370970573>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ANLOSDT2TM7CM3SGOPEAU2LRGSPKBANCNFSM4LEASJLQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services