[jira] [Commented] (HBASE-23811) [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty

["Wei-Chiu Chuang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032656#comment-17032656 ] 

Wei-Chiu Chuang commented on HBASE-23811:
-----------------------------------------

I tried to create a new Maven module in HBase, and created a shaded artifact org.apache.hbase:hbase-jaeger. While it worked and I was able to run tests from command line, IntelliJ doesn't load the shaded artifact if it is within the same project. Moving the artifact to hbase-thirdparty solved this problem. Not sure if this is the purpose of the hbase-thirdparty repo, but I'm happy now.

> [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty
> -----------------------------------------------------------------
>
>                 Key: HBASE-23811
>                 URL: https://issues.apache.org/jira/browse/HBASE-23811
>             Project: HBase
>          Issue Type: Sub-task
>          Components: thirdparty
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>
> JaegerTracing pulls in lots of dependencies. Some, like libthrift (0.13.0) conflicts the one ships in HBase (0.12.0).
> Additionally, not everyone may want to use Jaeger.
> I propose to shade JaegerTracing and its dependencies into an uber jar, place it as a hbase-thirdparty artifact. As an added benefit, this makes the management of tracers in the HBase's dependency tree much easier. Finally, we can follow the same suit and provide Zipkin tracer support in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)