[GitHub] garydgregory commented on a change in pull request #5: optimize map columns 2 properties code

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #5: optimize map columns 2 properties code
URL: https://github.com/apache/commons-dbutils/pull/5#discussion_r261832711
 
 

 ##########
 File path: src/main/java/org/apache/commons/dbutils/BeanProcessor.java
 ##########
 @@ -465,9 +465,6 @@ protected Method getWriteMethod(final Object target, final PropertyDescriptor pr
 
         for (int col = 1; col <= cols; col++) {
             String columnName = rsmd.getColumnLabel(col);
-            if (null == columnName || 0 == columnName.length()) {
 
 Review comment:
   This whole patch seems redundant with what JDBC specifies as the behavior for getColimnLabel(). What am I missing? This patch is workaround for buggy JDBC drivers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org