You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/12 04:12:09 UTC
[GitHub] [doris] yiguolei opened a new pull request, #15853: [refactor](remove unused code) remove buffer pool and disk io mgr
yiguolei opened a new pull request, #15853:
URL: https://github.com/apache/doris/pull/15853
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15853: [refactor](remove unused code) remove buffer pool and disk io mgr
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15853:
URL: https://github.com/apache/doris/pull/15853#issuecomment-1381201507
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15853: [refactor](remove unused code) remove buffer pool and disk io mgr
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15853:
URL: https://github.com/apache/doris/pull/15853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15853: [refactor](remove unused code) remove buffer pool and disk io mgr
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15853:
URL: https://github.com/apache/doris/pull/15853#discussion_r1067683936
##########
be/test/runtime/test_env.cc:
##########
@@ -34,8 +33,6 @@ TestEnv::TestEnv() {
// Some code will use ExecEnv::GetInstance(), so init the global ExecEnv singleton
_exec_env = ExecEnv::GetInstance();
_exec_env->_thread_mgr = new ThreadResourceMgr(2);
Review Comment:
warning: '_thread_mgr' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_exec_env->_thread_mgr = new ThreadResourceMgr(2);
^
```
**be/src/runtime/exec_env.h:208:** declared private here
```cpp
ThreadResourceMgr* _thread_mgr = nullptr;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -50,14 +47,8 @@
DCHECK(st.ok()) << st;
}
-void TestEnv::init_buffer_pool(int64_t min_page_len, int64_t capacity, int64_t clean_pages_limit) {
- _exec_env->_buffer_pool = new BufferPool(min_page_len, capacity, clean_pages_limit);
-}
-
TestEnv::~TestEnv() {
SAFE_DELETE(_exec_env->_result_queue_mgr);
- SAFE_DELETE(_exec_env->_buffer_pool);
- SAFE_DELETE(_exec_env->_disk_io_mgr);
SAFE_DELETE(_exec_env->_thread_mgr);
if (_engine == StorageEngine::_s_instance) {
Review Comment:
warning: '_s_instance' is a private member of 'doris::StorageEngine' [clang-diagnostic-error]
```cpp
if (_engine == StorageEngine::_s_instance) {
^
```
**be/src/olap/storage_engine.h:321:** declared private here
```cpp
d;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -34,8 +33,6 @@
// Some code will use ExecEnv::GetInstance(), so init the global ExecEnv singleton
_exec_env = ExecEnv::GetInstance();
_exec_env->_thread_mgr = new ThreadResourceMgr(2);
- _exec_env->_disk_io_mgr = new DiskIoMgr(1, 1, 1, 10);
- _exec_env->disk_io_mgr()->init(-1);
_exec_env->_result_queue_mgr = new ResultQueueMgr();
Review Comment:
warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_exec_env->_result_queue_mgr = new ResultQueueMgr();
^
```
**be/src/runtime/exec_env.h:204:** declared private here
```cpp
ResultQueueMgr* _result_queue_mgr = nullptr;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -50,14 +47,8 @@
DCHECK(st.ok()) << st;
}
-void TestEnv::init_buffer_pool(int64_t min_page_len, int64_t capacity, int64_t clean_pages_limit) {
- _exec_env->_buffer_pool = new BufferPool(min_page_len, capacity, clean_pages_limit);
-}
-
TestEnv::~TestEnv() {
SAFE_DELETE(_exec_env->_result_queue_mgr);
- SAFE_DELETE(_exec_env->_buffer_pool);
- SAFE_DELETE(_exec_env->_disk_io_mgr);
SAFE_DELETE(_exec_env->_thread_mgr);
Review Comment:
warning: '_thread_mgr' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
SAFE_DELETE(_exec_env->_thread_mgr);
^
```
**be/src/runtime/exec_env.h:208:** declared private here
```cpp
ThreadResourceMgr* _thread_mgr = nullptr;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -50,14 +47,8 @@
DCHECK(st.ok()) << st;
}
-void TestEnv::init_buffer_pool(int64_t min_page_len, int64_t capacity, int64_t clean_pages_limit) {
- _exec_env->_buffer_pool = new BufferPool(min_page_len, capacity, clean_pages_limit);
-}
-
TestEnv::~TestEnv() {
SAFE_DELETE(_exec_env->_result_queue_mgr);
Review Comment:
warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
SAFE_DELETE(_exec_env->_result_queue_mgr);
^
```
**be/src/runtime/exec_env.h:204:** declared private here
```cpp
ResultQueueMgr* _result_queue_mgr = nullptr;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15853: [refactor](remove unused code) remove buffer pool and disk io mgr
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15853:
URL: https://github.com/apache/doris/pull/15853#issuecomment-1379825872
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.65 seconds
load time: 500 seconds
storage size: 17120912260 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112051544_clickbench_pr_78260.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15853: [refactor](remove unused code) remove buffer pool and disk io mgr
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15853:
URL: https://github.com/apache/doris/pull/15853#issuecomment-1381201469
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org