You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by om...@apache.org on 2008/05/22 20:07:00 UTC

svn commit: r659184 - in /hadoop/core/trunk: ./ src/java/org/apache/hadoop/mapred/

Author: omalley
Date: Thu May 22 11:06:59 2008
New Revision: 659184

URL: http://svn.apache.org/viewvc?rev=659184&view=rev
Log:
HADOOP-3405. Made some map/reduce internal classes non-public:
MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, 
CompletedJobStatusStore. Contributed by Enis Soztutar.

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/CompletedJobStatusStore.java
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobProfile.java
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobStatus.java
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/MapTaskStatus.java
    hadoop/core/trunk/src/java/org/apache/hadoop/mapred/ReduceTaskStatus.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Thu May 22 11:06:59 2008
@@ -54,6 +54,10 @@
     HADOOP-3390. Removed deprecated ClientProtocol.abandonFileInProgress().
     (Tsz Wo (Nicholas), SZE via rangadi)
 
+    HADOOP-3405. Made some map/reduce internal classes non-public:
+    MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, 
+    CompletedJobStatusStore. (enis via omaley)
+
   NEW FEATURES
 
     HADOOP-3074. Provides a UrlStreamHandler for DFS and other FS,

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/CompletedJobStatusStore.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/CompletedJobStatusStore.java?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/CompletedJobStatusStore.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/CompletedJobStatusStore.java Thu May 22 11:06:59 2008
@@ -38,7 +38,7 @@
  * The retain time can be set with the 'persist.jobstatus.hours'
  * configuration variable (it is in hours).
  */
-public class CompletedJobStatusStore implements Runnable {
+class CompletedJobStatusStore implements Runnable {
   private boolean active;
   private String jobInfoDir;
   private long retainTime;

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobProfile.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobProfile.java?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobProfile.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobProfile.java Thu May 22 11:06:59 2008
@@ -74,6 +74,15 @@
   }
 
   /**
+   * @deprecated use JobProfile(String, JobID, String, String, String) instead
+   */
+  @Deprecated
+  public JobProfile(String user, String jobid, String jobFile, String url,
+      String name) {
+    this(user, JobID.forName(jobid), jobFile, url, name);
+  }
+  
+  /**
    * Get the user id.
    */
   public String getUser() {
@@ -88,6 +97,14 @@
   }
 
   /**
+   * @deprecated use getJobID() instead
+   */
+  @Deprecated
+  public String getJobId() {
+    return jobid.toString();
+  }
+  
+  /**
    * Get the configuration file for the job.
    */
   public String getJobFile() {

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobStatus.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobStatus.java?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobStatus.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobStatus.java Thu May 22 11:06:59 2008
@@ -74,6 +74,12 @@
   }
 
   /**
+   * @deprecated use getJobID instead
+   */
+  @Deprecated
+  public String getJobId() { return jobid.toString(); }
+  
+  /**
    * @return The jobid of the Job
    */
   public JobID getJobID() { return jobid; }

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java Thu May 22 11:06:59 2008
@@ -27,7 +27,7 @@
  * JobClient can use these methods to submit a Job for execution, and learn about
  * the current system status.
  */ 
-public interface JobSubmissionProtocol extends VersionedProtocol {
+interface JobSubmissionProtocol extends VersionedProtocol {
   /* 
    *Changing the versionID to 2L since the getTaskCompletionEvents method has
    *changed.

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/MapTaskStatus.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/MapTaskStatus.java?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/MapTaskStatus.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/MapTaskStatus.java Thu May 22 11:06:59 2008
@@ -19,7 +19,7 @@
 package org.apache.hadoop.mapred;
 
 
-public class MapTaskStatus extends TaskStatus {
+class MapTaskStatus extends TaskStatus {
 
   public MapTaskStatus() {}
 

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/mapred/ReduceTaskStatus.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/mapred/ReduceTaskStatus.java?rev=659184&r1=659183&r2=659184&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/mapred/ReduceTaskStatus.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/mapred/ReduceTaskStatus.java Thu May 22 11:06:59 2008
@@ -26,7 +26,7 @@
 
 
 
-public class ReduceTaskStatus extends TaskStatus {
+class ReduceTaskStatus extends TaskStatus {
 
   private long shuffleFinishTime; 
   private long sortFinishTime;