You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "moiseenkov (via GitHub)" <gi...@apache.org> on 2023/04/05 14:12:25 UTC
[GitHub] [airflow] moiseenkov opened a new pull request, #30487: Remove mysql-connector-python
moiseenkov opened a new pull request, #30487:
URL: https://github.com/apache/airflow/pull/30487
Remove mysql-connector-python library according to the Google SDK upgrade #30067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #30487: Remove mysql-connector-python
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30487:
URL: https://github.com/apache/airflow/pull/30487#discussion_r1160745876
##########
docs/apache-airflow/howto/set-up-database.rst:
##########
@@ -300,6 +300,14 @@ We recommend using the ``mysqlclient`` driver and specifying it in your SqlAlche
We also support the ``mysql-connector-python`` driver, which lets you connect through SSL
without any cert options provided.
+Unfortunately, this package depends on outdated version of ``protobuf<4.0`` which is no longer supported.
+If you wish to use ``mysql-connector-python`` driver, please install it with pip.
+
+.. code-block:: text
+
+ $ pip install mysql-connector-python
Review Comment:
Why? We enabled it as extra so the install should be with the extra
##########
docs/apache-airflow/howto/set-up-database.rst:
##########
@@ -300,6 +300,14 @@ We recommend using the ``mysqlclient`` driver and specifying it in your SqlAlche
We also support the ``mysql-connector-python`` driver, which lets you connect through SSL
without any cert options provided.
+Unfortunately, this package depends on outdated version of ``protobuf<4.0`` which is no longer supported.
Review Comment:
I think we should just explain that we have an extra option for another mysql client and in the extra info below we can explain that users should be aware of proto issue with link to the proto update request we submitted to the lib.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1517872675
Cool. Great to know it! @nmariz . Thanks for letting us know - looking forward to getting it fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1500368623
We might still of course "classify" it as breaking (nothing prevents us from doing so, we can announce any release breaking if we think doing so will prevent some common problems from our users).
But I personally don't think it is strong enough case to classify it as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1498961017
> Thank you all, I misunderstood the point.
>
> I will leave the code that uses `mysql-connector-python`, but is it true that we have to exclude this package from dependencies anyway? If I get it right, leaving `mysql-connector-python` here will cause dependency conflicts.
>
> My suggestion is removing the `mysql-connector-python` from the dependencies, and throwing an exception with a readable message whenever the package is used. Those users, who will face this issue, are always able to install this package manually and resolve possible conflicts on their own, or transition to the recommended library. @eladkal , @potiuk WDYT?
You can add optional dependencies (like mysql-connector-python in this case) via provider.yaml. We already have several examples of it. For example google provider has extra "[leveldb]" which brings in `plyvel` dependency.
https://github.com/apache/airflow/blob/main/airflow/providers/google/provider.yaml#L1121
And you should move mysql-connector-python there from main dependencies - following the same pattern.
There are a few more changes that will need to be added:
* The tests that are using `mysql-connector-python` will start failing, and that's fine - we need to separate them to a separate module and run `pytest.importorskip("mysql.connector") for that file - this will skip them on our CI, but if you manually add "mysql-connector-python" and run them, we could potentially have a separate job to run it on CI separately (and I will likely add it later) but for now skipping it is fine.
* In the original operator you should raise "AirflowOptionalProviderFeatureException" when import of mysql.connector fails (with some description that you need mysql-connector-python to be installed.
That should remove mysql-connector-python from installed dependencies and turn it's usage into, effectively optional feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on a diff in pull request #30487: Remove mysql-connector-python
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on code in PR #30487:
URL: https://github.com/apache/airflow/pull/30487#discussion_r1162822454
##########
docs/apache-airflow/howto/set-up-database.rst:
##########
@@ -300,6 +300,14 @@ We recommend using the ``mysqlclient`` driver and specifying it in your SqlAlche
We also support the ``mysql-connector-python`` driver, which lets you connect through SSL
without any cert options provided.
+Unfortunately, this package depends on outdated version of ``protobuf<4.0`` which is no longer supported.
+If you wish to use ``mysql-connector-python`` driver, please install it with pip.
+
+.. code-block:: text
+
+ $ pip install mysql-connector-python
Review Comment:
Thanks for noticing. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30487:
URL: https://github.com/apache/airflow/pull/30487#discussion_r1160632994
##########
tests/providers/mysql/hooks/test_mysql_connector_python.py:
##########
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import json
+from unittest import mock
+
+import pytest
+
+from airflow.models import Connection
+from airflow.providers.mysql.hooks.mysql import MySqlHook
+
+# Make sure that the optional package 'mysql-connector-python' is installed (which is not by default)
+_ = pytest.importorskip("mysql")
Review Comment:
```suggestion
pytest.importorskip("mysql")
```
No need to add ` _=`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #30487: Remove mysql-connector-python
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30487:
URL: https://github.com/apache/airflow/pull/30487#discussion_r1162848040
##########
airflow/providers/mysql/provider.yaml:
##########
@@ -23,6 +23,7 @@ description: |
suspended: false
versions:
+ - 4.0.3
Review Comment:
```suggestion
```
Since we decided ita not breaking change no need to specify version. Version will be set on release
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.3
+.....
+
+Misc
+~~~~
+
+* ``Turn the package mysql-connector-python optional (dependency moved to extra) (#30487)``
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1517039983
> So at least that answer contains information.
Let's see. Yes it's interesting that they respond differently to different issues. But - it is not an issue for us any more. It's issue for them after we merged this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on pull request #30487: Remove mysql-connector-python
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1506819464
@potiuk , hi, can we merge it please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] notatallshaw-gts commented on pull request #30487: Remove mysql-connector-python
Posted by "notatallshaw-gts (via GitHub)" <gi...@apache.org>.
notatallshaw-gts commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1516429143
FYI I see they actually replied in a more useful manner on this post that they are facing a bug in protobuf with trying to upgrade to protobuf 4: https://forums.mysql.com/read.php?50,708753,708764#msg-708764
> We are currently working on upgrading Python Protobuf to 4.x in the upcoming release, but we are facing a blocker. A bug in the latest protobuf version (https://github.com/protocolbuffers/protobuf/issues/12373) is affecting our implementation.
From: Jarek Potiuk ***@***.***>
Sent: Thursday, April 20, 2023 6:12 AM
To: apache/airflow ***@***.***>
Cc: Damian Shaw ***@***.***>; Manual ***@***.***>
Subject: Re: [apache/airflow] Remove mysql-connector-python (PR #30487)
FYI. MySQL does not really collaboarate. They released a new version of mysql-connector-python 8.0.33` two days ago, but it still has < 3.20 limit on protobuf. Also, I got this - completely useless and apparently automatically generated response today to my issue:
Here are the general steps to upgrade to a newer version of protobuf:
Check compatibility: Before upgrading to a newer version of protobuf, check if the new version is compatible with your current codebase and other dependencies. Review the release notes and documentation to see if there are any changes or deprecations that could affect your code.
Update protobuf files: If you have any custom protobuf files, update them to the latest version. You can use the protoc compiler to generate updated code from the new protobuf files.
Update dependencies: If you are using a language-specific implementation of protobuf (such as the Python protobuf package or the Java protobuf library), update your dependencies to the latest version.
Update code: Update your code to use the new version of protobuf. This may involve updating method signatures, changing import statements, and updating serialization/deserialization code.
Test thoroughly: After making the updates, test your code thoroughly to ensure that everything works as expected. Test both positive and negative cases to ensure that there are no regressions or new issues introduced by the upgrade.
Roll back if necessary: If you encounter any issues or compatibility problems, be prepared to roll back to the previous version of protobuf until the issues can be resolved.
By following these steps, you should be able to successfully upgrade to a newer version of protobuf while minimizing the risk of compatibility issues and regressions.
I answered appropriately : https://forums.mysql.com/read.php?50,708413,708803#msg-708803
—
Reply to this email directly, view it on GitHub<https://github.com/apache/airflow/pull/30487#issuecomment-1516073030>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2RHOLEW646OZOLINFQNFTTXCEDYDANCNFSM6AAAAAAWUEJ3QI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
________________________________
Strike Technologies, LLC (“Strike”) is part of the GTS family of companies. Strike is a technology solutions provider, and is not a broker or dealer and does not transact any securities related business directly whatsoever. This communication is the property of Strike and its affiliates, and does not constitute an offer to sell or the solicitation of an offer to buy any security in any jurisdiction. It is intended only for the person to whom it is addressed and may contain information that is privileged, confidential, or otherwise protected from disclosure. Distribution or copying of this communication, or the information contained herein, by anyone other than the intended recipient is prohibited. If you have received this communication in error, please immediately notify Strike at ***@***.***, and delete and destroy any copies hereof.
________________________________
CONFIDENTIALITY / PRIVILEGE NOTICE: This transmission and any attachments are intended solely for the addressee. This transmission is covered by the Electronic Communications Privacy Act, 18 U.S.C ''2510-2521. The information contained in this transmission is confidential in nature and protected from further use or disclosure under U.S. Pub. L. 106-102, 113 U.S. Stat. 1338 (1999), and may be subject to attorney-client or other legal privilege. Your use or disclosure of this information for any purpose other than that intended by its transmittal is strictly prohibited, and may subject you to fines and/or penalties under federal and state law. If you are not the intended recipient of this transmission, please DESTROY ALL COPIES RECEIVED and confirm destruction to the sender via return transmittal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30487:
URL: https://github.com/apache/airflow/pull/30487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1500193432
This looks cool and has the desired effect, mysql-connector-python is removed from the image:
https://github.com/apache/airflow/actions/runs/4636423980/jobs/8204304593?pr=30487#step:5:18767
```
2c2
< # This constraints file was automatically generated on 2023-04-06T12:47:16Z
---
> # This constraints file was automatically generated on 2023-04-07T07:51:23Z
77c77
< aws-sam-translator==1.63.0
---
> aws-sam-translator==1.64.0
81c81
< azure-core==1.26.3
---
> azure-core==1.26.4
88c88
< azure-mgmt-core==1.3.2
---
> azure-mgmt-core==1.4.0
141c141
< coverage==7.2.2
---
> coverage==7.2.3
175c175
< filelock==3.10.7
---
> filelock==3.11.0
321c321
< mypy-boto3-rds==1.26.102
---
> mypy-boto3-rds==1.26.108
325d324
< mysql-connector-python==8.0.32
473c472
< slack-sdk==3.20.2
---
> slack-sdk==3.21.0
```
However the side-effect is that some new warnings are generated while importing requests (See the failing testts - it contains explanation what to do to mark the warnings as "known" - those do not seem as harmful ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #30487: Remove mysql-connector-python
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1500351070
Also please update PR title + description so users won't get the wrong impression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #30487: Remove mysql-connector-python
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1500404859
> I am not 100% sure if it is breaking to be honest. We already agreed that dependency changes are non-breaking and assuming somoene already has installed mysql-connector-python, it will continue to work after the upgrade.
I'm ok with not listing it as breaking as long as we have a change log entry that explains what is changed. 2-3 lines in enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on a diff in pull request #30487: Remove mysql-connector-python
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on code in PR #30487:
URL: https://github.com/apache/airflow/pull/30487#discussion_r1162822850
##########
docs/apache-airflow/howto/set-up-database.rst:
##########
@@ -300,6 +300,14 @@ We recommend using the ``mysqlclient`` driver and specifying it in your SqlAlche
We also support the ``mysql-connector-python`` driver, which lets you connect through SSL
without any cert options provided.
+Unfortunately, this package depends on outdated version of ``protobuf<4.0`` which is no longer supported.
Review Comment:
Good point, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1507061518
Rebased once more after merging the #30625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on pull request #30487: Remove mysql-connector-python
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1498721447
Thank you all, I misunderstood the point.
I will leave the code that uses `mysql-connector-python`, but is it true that we have to exclude this package from dependencies anyway? If I get it right, leaving `mysql-connector-python` here will cause dependency conflicts.
My suggestion is removing the `mysql-connector-python` from the dependencies, and throwing an exception with a readable message whenever the package is used. Those users, who will face this issue, are always able to install this package manually and resolve possible conflicts on their own, or transition to the recommended library. @eladkal , @potiuk WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1506857831
I saw that for some reasons checks were not running. I rebased to rebuild it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] notatallshaw-gts commented on pull request #30487: Remove mysql-connector-python
Posted by "notatallshaw-gts (via GitHub)" <gi...@apache.org>.
notatallshaw-gts commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1503519557
I have a few clarifying questions about this PR:
* Will `mysql-connector-python` will not be included in the `all` extra?
* If a user uses the `mysql-connector-python` extra will it be incompatible with other extras (those that rely on `protobuf>=4`)?
* The constraints file generated for the following releases will not be compatible with the `mysql-connector-python` extra?
I assume the answer to all of these is yes and if so can it be made clear in this changelog and/or the release notes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1516073030
FYI. MySQL does not really collaboarate. They released a new version of `mysql-connector-python `8.0.33` two days ago, but it still has < 3.20 limit on protobuf. Also, I got this - completely useless and apparently automatically generated response today to my issue:
> Here are the general steps to upgrade to a newer version of protobuf:
>
> Check compatibility: Before upgrading to a newer version of protobuf, check if the new version is compatible with your current codebase and other dependencies. Review the release notes and documentation to see if there are any changes or deprecations that could affect your code.
>
> Update protobuf files: If you have any custom protobuf files, update them to the latest version. You can use the protoc compiler to generate updated code from the new protobuf files.
>
> Update dependencies: If you are using a language-specific implementation of protobuf (such as the Python protobuf package or the Java protobuf library), update your dependencies to the latest version.
>
> Update code: Update your code to use the new version of protobuf. This may involve updating method signatures, changing import statements, and updating serialization/deserialization code.
>
> Test thoroughly: After making the updates, test your code thoroughly to ensure that everything works as expected. Test both positive and negative cases to ensure that there are no regressions or new issues introduced by the upgrade.
>
> Roll back if necessary: If you encounter any issues or compatibility problems, be prepared to roll back to the previous version of protobuf until the issues can be resolved.
>
> By following these steps, you should be able to successfully upgrade to a newer version of protobuf while minimizing the risk of compatibility issues and regressions.
I answered appropriately : https://forums.mysql.com/read.php?50,708413,708803#msg-708803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nmariz commented on pull request #30487: Remove mysql-connector-python
Posted by "nmariz (via GitHub)" <gi...@apache.org>.
nmariz commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1517599867
(Disclaimer: I'm the lead developer of Connector/Python)
Like mentioned by @notatallshaw-gts, MySQL Connector/Python has a blocker (see https://github.com/protocolbuffers/protobuf/issues/12373) for upgrading to Protobuf 4.22.x.
We are trying our best to find workarounds. However, in our case, it only affects us with Protobuf +4.22.0. So, in case Protobuf bug is not fixed on time, we are adding support until Protobuf 4.21.12 in the upcoming release.
@potiuk I'm sorry very about the late reply on the forum. This indeed is the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on pull request #30487: Remove mysql-connector-python
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1499087651
Thanks for the explanation. I updated the PR, please re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30487: Remove mysql-connector-python
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30487:
URL: https://github.com/apache/airflow/pull/30487#issuecomment-1500364047
I am not 100% sure if it is breaking to be honest. We already agreed that dependency changes are non-breaking and assuming somoene already has installed mysql-connector-python, it will continue to work after the upgrade.
Breaking means - if somoene upgrades the provider, things will break. Which is not necessarily true - if someone upgrade from past provider, things will continue to work (because the user will have mysql-connector-python already installed). The user might be prevented from installing the newer provider (because of protobuf for example) but this also does not mean that it's a "breaking change".
I think, technically speaking, it's not "strongly" breaking - the usual "breaking" pattern when things break when you upgrade does not "technically" apply.
There are other scenarios where things might break - for example when you upgrade airflow image and you expect mysql operators to continue to work. But also technically it is not breaking, because images are "convenience" binaries, and while people might use them in charts, they are not even versioned with breakin/non-breaking (because they contain combination of airflow + possibly breaking providers).
So I am not really sure if we should classify that change as breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org