You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/08/20 14:03:46 UTC
[GitHub] zeppelin pull request #3153: [ZEPPELIN-3738] Fix enabling JMX in ZeppelinSer...
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3153
[ZEPPELIN-3738] Fix enabling JMX in ZeppelinServer
### What is this PR for?
There is a typo in the system variable name `ZEPPELIN_JMX_ENABLE`:
```
// Register MBean
if ("true".equals(System.getenv("ZEPPELIN_ENABLE_JMX"))) {
```
Variable defined in zeppelin-env.sh.template ([[ZEPPELIN-3422]](https://issues.apache.org/jira/browse/ZEPPELIN-3422)):
```
# export ZEPPELIN_JMX_ENABLE # Enable JMX feature by defining "true"
```
Also ZEPPELIN_JMX_ENABLE not mentioned in docs.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* [issue](https://issues.apache.org/jira/browse/ZEPPELIN-3738)
### How should this be tested?
* CI pass
* Tested manually during [[ZEPPELIN-3671]](https://github.com/apache/zeppelin/pull/3110)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Docs updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3738
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3153
----
commit 4e5ffca4e6454548908614e54d4986908481b183
Author: egorklimov <kl...@...>
Date: 2018-08-20T10:30:44Z
Docs updated & bug fixed
----
---
[GitHub] zeppelin issue #3153: [ZEPPELIN-3738] Fix enabling JMX in ZeppelinServer
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3153
LGTM
---
[GitHub] zeppelin pull request #3153: [ZEPPELIN-3738] Fix enabling JMX in ZeppelinSer...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3153
---
[GitHub] zeppelin issue #3153: [ZEPPELIN-3738] Fix enabling JMX in ZeppelinServer
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3153
Thanks. LGTM
---