You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jung JaeHwa <jh...@gruter.com> on 2014/02/21 09:33:41 UTC
Review Request 18349: TAJO-590: Rename HiveConverter to HiveQLAnalyzer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18349/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-590
https://issues.apache.org/jira/browse/TAJO-590
Repository: tajo
Description
-------
SQL and HiveQL are all just parser frontend. They are the same level compoenents. HiveQLAnalyzer looks more proper name than HiveQLConverter. We rename it.
Diffs
-----
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveLexer.g4 6595655
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveParser.g4 d3829a4
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4 PRE-CREATION
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLParser.g4 PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java a762720
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java 325f7db
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java 2c3ddfe
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveConverter.java e445c92
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java PRE-CREATION
Diff: https://reviews.apache.org/r/18349/diff/
Testing
-------
mvn clean install
Thanks,
Jung JaeHwa
Re: Review Request 18349: TAJO-590: Rename HiveConverter to HiveQLAnalyzer
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18349/#review35140
-----------------------------------------------------------
+1
It's a rename issue. The patch looks straightforward.
- Hyunsik Choi
On Feb. 21, 2014, 5:33 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18349/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 5:33 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-590
> https://issues.apache.org/jira/browse/TAJO-590
>
>
> Repository: tajo
>
>
> Description
> -------
>
> SQL and HiveQL are all just parser frontend. They are the same level compoenents. HiveQLAnalyzer looks more proper name than HiveQLConverter. We rename it.
>
>
> Diffs
> -----
>
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveLexer.g4 6595655
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveParser.g4 d3829a4
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4 PRE-CREATION
> tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLParser.g4 PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java a762720
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java PRE-CREATION
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java 325f7db
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java 2c3ddfe
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveConverter.java e445c92
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18349/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Jung JaeHwa
>
>