You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jmesnil <gi...@git.apache.org> on 2017/02/07 09:12:18 UTC

[GitHub] activemq-artemis pull request #991: [ARTEMIS-931] Fix HTTP Upgrade Connectio...

GitHub user jmesnil opened a pull request:

    https://github.com/apache/activemq-artemis/pull/991

    [ARTEMIS-931] Fix HTTP Upgrade Connection

    * Fix isEquivalent() method to take into account the activemqServerName
      property when httpUpgradeEnabled is true. Two ActiveMQ server hosted on
      the same app server may have the same host and port (corresponding to
      the Web server HTTP port). The activemqServerName property is used to
      distinguish them.
    * Iron out HTTP upgrade handler so that the latch is always count down
      and the channel context is closed unless the handshake was completed
      successfully
    
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-931

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-931_improve_http-upgrade_connection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #991
    
----
commit dd052026e6c5616f1f51795ea21d26f12deaf9e7
Author: Jeff Mesnil <jm...@gmail.com>
Date:   2017-02-06T15:26:02Z

    [ARTEMIS-931] Fix HTTP Upgrade Connection
    
    * Fix isEquivalent() method to take into account the activemqServerName
      property when httpUpgradeEnabled is true. Two ActiveMQ server hosted on
      the same app server may have the same host and port (corresponding to
      the Web server HTTP port). The activemqServerName property is used to
      distinguish them.
    * Iron out HTTP upgrade handler so that the latch is always count down
      and the channel context is closed unless the handshake was completed
      successfully
    
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-931

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #991: [ARTEMIS-931] Fix HTTP Upgrade Connection

Posted by jmesnil <gi...@git.apache.org>.
Github user jmesnil commented on the issue:

    https://github.com/apache/activemq-artemis/pull/991
  
    There is no test in Artemis codebase dealing with HTTP upgrade as the handler on the server side is part of the app server.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #991: [ARTEMIS-931] Fix HTTP Upgrade Connectio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/991


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---