You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Karthik Kambatla (JIRA)" <ji...@apache.org> on 2012/11/15 21:07:12 UTC
[jira] [Created] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Karthik Kambatla created HADOOP-9049:
----------------------------------------
Summary: DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
Key: HADOOP-9049
URL: https://issues.apache.org/jira/browse/HADOOP-9049
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Currently, DelegationTokenRenewer is not singleton.
Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501918#comment-13501918 ]
Hudson commented on HADOOP-9049:
--------------------------------
Integrated in Hadoop-trunk-Commit #3053 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3053/])
HADOOP-9049. DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from. Contributed by Karthik Kambatla. (Revision 1412077)
Result = SUCCESS
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412077
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498565#comment-13498565 ]
Hadoop QA commented on HADOOP-9049:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553722/hadoop-9049.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1756//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1756//console
This message is automatically generated.
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500310#comment-13500310 ]
Daryn Sharp commented on HADOOP-9049:
-------------------------------------
+1 But I'd suggest canceling the token in {{removeRenewAction}}. Hftp & webhdfs only register tokens for renewal that are implicitly created for internal use. Since they aren't cancelled, it causes a bunch of defunct tokens to clog the NN until they expire. If you want to fix it on another jira, I'm fine with that.
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500425#comment-13500425 ]
Karthik Kambatla commented on HADOOP-9049:
------------------------------------------
Hi Daryn,
Thanks for the review.
I have filed HADOOP-9064 to add canceling the token. I feel we should pass a boolean to {{#removeRenewAction(boolean cancel)}} and cancel the token accordingly. The filesystems can call removeRenewAction with cancel set to true.
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karthik Kambatla updated HADOOP-9049:
-------------------------------------
Attachment: hadoop-9049.patch
Thanks Daryn. Definitely looking forward for your full review.
Meanwhile, I am uploading a new patch to address Daryn's comments:
# make getInstance() synchronized and make INSTANCE non-volatile
# call super.close() in close() of WebHdfs and Hftp FS
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karthik Kambatla updated HADOOP-9049:
-------------------------------------
Attachment: hadoop-9049.patch
Attaching the latest patch from HDFS-4009.patch
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502758#comment-13502758 ]
Hudson commented on HADOOP-9049:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1234 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1234/])
HADOOP-9049. DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from. Contributed by Karthik Kambatla. (Revision 1412077)
Result = SUCCESS
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412077
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Fix For: 2.0.3-alpha
>
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karthik Kambatla reassigned HADOOP-9049:
----------------------------------------
Assignee: Karthik Kambatla
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498446#comment-13498446 ]
Daryn Sharp commented on HADOOP-9049:
-------------------------------------
I need to look at this more, but you need to synch the getInstance, and call super in close().
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karthik Kambatla updated HADOOP-9049:
-------------------------------------
Status: Patch Available (was: Open)
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501960#comment-13501960 ]
Hudson commented on HADOOP-9049:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1264 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1264/])
HADOOP-9049. DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from. Contributed by Karthik Kambatla. (Revision 1412077)
Result = FAILURE
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412077
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Fix For: 2.0.3-alpha
>
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498382#comment-13498382 ]
Hadoop QA commented on HADOOP-9049:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553694/hadoop-9049.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1754//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1754//console
This message is automatically generated.
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502711#comment-13502711 ]
Hudson commented on HADOOP-9049:
--------------------------------
Integrated in Hadoop-Yarn-trunk #44 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/44/])
HADOOP-9049. DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from. Contributed by Karthik Kambatla. (Revision 1412077)
Result = SUCCESS
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412077
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDelegationTokenRenewer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Fix For: 2.0.3-alpha
>
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be
Singleton and FileSystems should register/deregister to/from.
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-9049:
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this. Thanks for the patch, Karthik, and for the review, Daryn.
> DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9049
> URL: https://issues.apache.org/jira/browse/HADOOP-9049
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.2-alpha
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Fix For: 2.0.3-alpha
>
> Attachments: hadoop-9049.patch, hadoop-9049.patch
>
>
> Currently, DelegationTokenRenewer is not singleton.
> Each filesystem using it spawns its own DelegationTokenRenewer. Also, they don't stop the Renewer leading to other problems.
> A single DelegationTokenRenewer should be sufficient for all FileSystems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira