You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "tbonelee (via GitHub)" <gi...@apache.org> on 2025/12/03 08:42:47 UTC

[PR] [ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area [zeppelin]

tbonelee opened a new pull request, #5124:
URL: https://github.com/apache/zeppelin/pull/5124

   ### What is this PR for?
   
   #### Summary
   
   - Fixed dropdown menu items in header where only text was clickable instead of the full item area
   - Changed routerLinkActive to nzMatchRouter for proper NG-ZORRO integration
   - Added CSS pseudo-element to expand clickable area of anchor tags
   
   #### Cause
   
   - Likely due to NG-ZORRO dropdown menu item anchor tag style changes that reduced the clickable area to just the text content.
   
   #### Changes
   
   - Updated `header.component.html`: Replace `routerLinkActive` with `nzMatchRouter` directive
   - Updated `global.less`: Add `::before` pseudo-element to `.ant-dropdown-menu-item > a` to expand clickable area using absolute positioning
   
   ### What type of PR is it?
   Bug Fix
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-6384
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5124:
URL: https://github.com/apache/zeppelin/pull/5124


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5124:
URL: https://github.com/apache/zeppelin/pull/5124#issuecomment-4188357619

   Thanks for the review. I've merged this into `master` and `branch-0.12`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5124:
URL: https://github.com/apache/zeppelin/pull/5124#issuecomment-4187371612

   @jongyoul @ParkGyeongTae Could you take a look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org