[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #349: Add support for JSON formatting of infoset

[GitBox <gi...@apache.org>]

mbeckerle commented on code in PR #349:
URL: https://github.com/apache/daffodil-vscode/pull/349#discussion_r1036047664


##########
src/infoset.ts:
##########
@@ -46,8 +46,8 @@ async function openInfosetFilePrompt() {
 
     switch (action) {
       case 'Open':
-        let xml = await vscode.workspace.openTextDocument(uri)
-        await vscode.window.showTextDocument(xml, {
+        let data = await vscode.workspace.openTextDocument(uri)

Review Comment:
   Do you really want to call this value "data" ? How about "infoset". Normally we think of data as the input to parse, and infoset as the output from parse, and most of your code follows that naming.
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org