You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 19:10:57 UTC
svn commit: r1775541 -
/jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java
Author: pmouawad
Date: Wed Dec 21 19:10:57 2016
New Revision: 1775541
URL: http://svn.apache.org/viewvc?rev=1775541&view=rev
Log:
Sonar : Fix errors and code smells
Clarify code by renaming vars
Modified:
jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java?rev=1775541&r1=1775540&r2=1775541&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java Wed Dec 21 19:10:57 2016
@@ -64,14 +64,14 @@ abstract public class AbstractSampleWrit
* The destination writer where samples will be written by this
* sample writer
*/
- public void setWriter(Writer writer) {
- Validate.notNull(writer, "writer must not be null.");
+ public void setWriter(Writer newWriter) {
+ Validate.notNull(newWriter, "writer must not be null.");
if (this.writer != null) {
// flush and close previous writer
JOrphanUtils.closeQuietly(this.writer);
}
- this.writer = new PrintWriter(new BufferedWriter(writer, BUF_SIZE), false);
+ this.writer = new PrintWriter(new BufferedWriter(newWriter, BUF_SIZE), false);
}
/**
@@ -83,7 +83,7 @@ abstract public class AbstractSampleWrit
* The output stream on which sample should be written
*/
public void setOutputStream(OutputStream out) {
- Validate.notNull(out, "out must not be null.");
+ Validate.notNull(out, "out must not be null."); // NOSONAR
try {
setWriter(new OutputStreamWriter(out, CHARSET));
@@ -102,7 +102,7 @@ abstract public class AbstractSampleWrit
public void setOutputFile(File output) {
FileOutputStream fos = null;
try {
- fos = new FileOutputStream(output);
+ fos = new FileOutputStream(output); // NOSONAR
} catch (Exception e) {
throw new SampleException(e.getMessage(), e);
}