You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/26 11:25:21 UTC

[GitHub] [flink] twalthr opened a new pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

twalthr opened a new pull request #15388:
URL: https://github.com/apache/flink/pull/15388


   ## What is the purpose of the change
   
   Enables to fully rely on the watermark strategy provided by the ScanTableSource itself.
   
   ## Brief change log
   
   - Add a SupportsSourceWatermark ability interface
   - Add ability spec
   - Change planner rules
   
   ## Verifying this change
   
   This change added tests and can be verified as follows: `TableSourceTest`
   
   A full integration test will follow in one of the next PRs.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808143847


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f142c9ff3d9935c49a1f91753a2b3bac8db39e8f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808143847


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544",
       "triggerID" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f142c9ff3d9935c49a1f91753a2b3bac8db39e8f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808143847


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544",
       "triggerID" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15556",
       "triggerID" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 86af77291d43968516b35185fc08954d4dd3d64f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808143847


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544",
       "triggerID" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15556",
       "triggerID" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f142c9ff3d9935c49a1f91753a2b3bac8db39e8f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544) 
   * 86af77291d43968516b35185fc08954d4dd3d64f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808140457


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 86af77291d43968516b35185fc08954d4dd3d64f (Sat Aug 28 10:34:23 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #15388:
URL: https://github.com/apache/flink/pull/15388


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808140457


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f142c9ff3d9935c49a1f91753a2b3bac8db39e8f (Fri Mar 26 11:30:23 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808143847


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544",
       "triggerID" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f142c9ff3d9935c49a1f91753a2b3bac8db39e8f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544) 
   * 86af77291d43968516b35185fc08954d4dd3d64f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808137438


   CC @wuchong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15388: [FLINK-21989][table] Add a SupportsSourceWatermark ability interface

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15388:
URL: https://github.com/apache/flink/pull/15388#issuecomment-808143847


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544",
       "triggerID" : "f142c9ff3d9935c49a1f91753a2b3bac8db39e8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15556",
       "triggerID" : "86af77291d43968516b35185fc08954d4dd3d64f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f142c9ff3d9935c49a1f91753a2b3bac8db39e8f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15544) 
   * 86af77291d43968516b35185fc08954d4dd3d64f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org