You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2021/06/29 09:31:29 UTC
[hadoop] branch trunk updated: HDFS-16092. Avoid creating
LayoutFlags redundant objects (#3150)
This is an automated email from the ASF dual-hosted git repository.
weichiu pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 93a1685 HDFS-16092. Avoid creating LayoutFlags redundant objects (#3150)
93a1685 is described below
commit 93a1685073d76bef5c6ad3819e7710317733bd7a
Author: Viraj Jasani <vj...@apache.org>
AuthorDate: Tue Jun 29 15:01:02 2021 +0530
HDFS-16092. Avoid creating LayoutFlags redundant objects (#3150)
---
.../main/java/org/apache/hadoop/hdfs/protocol/LayoutFlags.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutFlags.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutFlags.java
index 1d14973..1cf12a0 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutFlags.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutFlags.java
@@ -31,14 +31,15 @@ import org.apache.hadoop.classification.InterfaceAudience;
*/
@InterfaceAudience.Private
public class LayoutFlags {
+
/**
- * Load a LayoutFlags object from a stream.
+ * Read next int from given input stream. If the value is not 0 (unsupported
+ * feature flags), throw appropriate IOException.
*
* @param in The stream to read from.
- * @throws IOException
+ * @throws IOException If next byte read from given stream is not 0.
*/
- public static LayoutFlags read(DataInputStream in)
- throws IOException {
+ public static void read(DataInputStream in) throws IOException {
int length = in.readInt();
if (length < 0) {
throw new IOException("The length of the feature flag section " +
@@ -47,7 +48,6 @@ public class LayoutFlags {
throw new IOException("Found feature flags which we can't handle. " +
"Please upgrade your software.");
}
- return new LayoutFlags();
}
private LayoutFlags() {
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org