You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by su...@apache.org on 2015/06/12 21:41:21 UTC
trafficserver git commit: [TS-3677]: Coverity CID # 1304799.
Repository: trafficserver
Updated Branches:
refs/heads/master 91513e325 -> fc2de7004
[TS-3677]: Coverity CID # 1304799.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/fc2de700
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/fc2de700
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/fc2de700
Branch: refs/heads/master
Commit: fc2de70049f79338a847fe03ffaa137f4e800ba6
Parents: 91513e3
Author: John Rushford <Jo...@cable.comcast.com>
Authored: Fri Jun 12 19:40:28 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Fri Jun 12 19:41:12 2015 +0000
----------------------------------------------------------------------
.../cache_range_requests/cache_range_requests.cc | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fc2de700/plugins/experimental/cache_range_requests/cache_range_requests.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/cache_range_requests/cache_range_requests.cc b/plugins/experimental/cache_range_requests/cache_range_requests.cc
index 0bff2ec..f67ca2b 100644
--- a/plugins/experimental/cache_range_requests/cache_range_requests.cc
+++ b/plugins/experimental/cache_range_requests/cache_range_requests.cc
@@ -35,7 +35,6 @@
struct txndata {
char *range_value;
- char *request_url;
};
static void handle_read_request_header(TSCont, TSEvent, void *);
@@ -104,10 +103,9 @@ range_header_check(TSHttpTxn txnp)
req_url = TSHttpTxnEffectiveUrlStringGet(txnp, &url_length);
snprintf(cache_key_url, 8192, "%s-%s", req_url, txn_state->range_value);
TSDebug(PLUGIN_NAME, "Rewriting cache URL for %s to %s", req_url, cache_key_url);
- txn_state->request_url = (char *)TSmalloc(url_length + 1);
- strncpy(txn_state->request_url, req_url, url_length);
- txn_state->request_url[url_length] = 0;
-
+ if (req_url) {
+ TSfree(req_url);
+ }
// set the cache key.
if (TS_SUCCESS != TSCacheUrlSet(txnp, cache_key_url, strlen(cache_key_url))) {
TSDebug(PLUGIN_NAME, "TSCacheUrlSet(): failed to change the cache url to %s.", cache_key_url);
@@ -411,9 +409,12 @@ transaction_handler(TSCont contp, TSEvent event, void *edata)
break;
case TS_EVENT_HTTP_TXN_CLOSE:
TSDebug(PLUGIN_NAME, "Starting handle_transaction_close().");
- TSfree(txn_state);
- TSfree(txn_state->range_value);
- TSfree(txn_state->request_url);
+ if (txn_state) {
+ if (txn_state->range_value) {
+ TSfree(txn_state->range_value);
+ }
+ TSfree(txn_state);
+ }
TSContDestroy(contp);
break;
default: