You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/10/12 09:09:06 UTC
[PR] test(runtime-host): use the production startup wait budget [maka]
Astro-Han opened a new pull request, #6080:
URL: https://github.com/apache/maka/pull/6080
## Summary
The 0.2.1 source-candidate run failed two owner-lifecycle tests before their lifecycle assertions: the shared test helper stopped waiting for the real Host after five seconds. Use the existing production election deadline for this startup wait. Owner-loss and shutdown deadlines, lifecycle assertions, and production behavior are unchanged.
This keeps the source-release tests aligned with the supported startup budget and unblocks candidate verification without adding a release-specific path.
## Verification
- A temporary six-second delay before the real Candidate bootstrap reproduced the same `unavailable` failure in all three targeted lifecycle tests with the old five-second helper. With the production startup deadline, all three passed and retained their owner-loss assertions.
- The complete `host-kernel` file passed 90/90 with that controlled delay. After removing the probe and forcing a rebuild, the three targeted tests passed with normal startup.
- Runtime Host build and typecheck, root format and lint, and `git diff --check` passed. The formal source-candidate workflow will rerun the extracted-source checks after merge.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex diagnosed the source-candidate failure, implemented the test-helper change, and ran the controlled reproduction and validation.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): use the production startup wait budget [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6080:
URL: https://github.com/apache/maka/pull/6080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): use the production startup wait budget [maka]
Posted by "Sun-GLiang (via GitHub)" <gi...@apache.org>.
Sun-GLiang commented on PR #6080:
URL: https://github.com/apache/maka/pull/6080#issuecomment-6123146155
Reviewed the change and the relevant helper call sites. Reusing DEFAULT_ELECTION_DEADLINE_MS aligns the test startup wait with the production budget while preserving the existing owner-loss and shutdown assertions and deadlines. I found no blocking issues.
The PR’s test check passed. I did not rerun the tests locally or independently reproduce the six-second startup-delay experiment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org