You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Roman Leventov (Jira)" <ji...@apache.org> on 2020/01/31 14:58:00 UTC
[jira] [Commented] (FLINK-15838) Dangling
CountDownLatch.await(timeout)
[ https://issues.apache.org/jira/browse/FLINK-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027563#comment-17027563 ]
Roman Leventov commented on FLINK-15838:
----------------------------------------
See also [https://github.com/code-review-checklists/java-concurrency#check-await], [https://youtrack.jetbrains.com/issue/IDEA-231640]
> Dangling CountDownLatch.await(timeout)
> --------------------------------------
>
> Key: FLINK-15838
> URL: https://issues.apache.org/jira/browse/FLINK-15838
> Project: Flink
> Issue Type: Bug
> Reporter: Roman Leventov
> Priority: Major
>
> There are 16 occurrences in the codebase (all in test code) when the result of CountDownLatch.await(timeout, TimeUnit) is not checked. It's like not checking the result of File.delete(). The common fix is to wrap CDL.await() call into assertTrue().
> All 16 places could be found using the following structural search in IntelliJ:
> $x$.await($y$, $z$);
> With "CountDownLatch" type constraint on the $x$ variable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)