[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8034: [viz] Adding get_def typing

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8034: [viz] Adding get_def typing
URL: https://github.com/apache/incubator-superset/pull/8034#discussion_r313211604
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -725,7 +726,7 @@ class MarkupViz(BaseViz):
     def query_obj(self):
         return None
 
-    def get_df(self, query_obj=None):
+    def get_df(self, query_obj: Dict[str, Any] = None) -> Optional[pd.DataFrame]:
 
 Review comment:
   same comment here as above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org