You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2019/03/30 18:04:18 UTC
[pulsar] branch master updated: By default use
`journalFormatVersionToWrite=5` for Bookie journal (#3890)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new b6c509a By default use `journalFormatVersionToWrite=5` for Bookie journal (#3890)
b6c509a is described below
commit b6c509a561402b7e2acf64829e2b964a9197b5ea
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Sat Mar 30 11:04:13 2019 -0700
By default use `journalFormatVersionToWrite=5` for Bookie journal (#3890)
* By default use `journalFormatVersionToWrite=5` for Bookie journal
* Also set fileInfoFormatVersionToWrite=0
---
conf/bookkeeper.conf | 29 +++++++++++++++++++++--------
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/conf/bookkeeper.conf b/conf/bookkeeper.conf
index 337d603..9df49d2 100644
--- a/conf/bookkeeper.conf
+++ b/conf/bookkeeper.conf
@@ -74,8 +74,8 @@ bookieDeathWatchInterval=1000
# When entryLogPerLedgerEnabled is enabled, checkpoint doesn't happens
# when a new active entrylog is created / previous one is rolled over.
# Instead SyncThread checkpoints periodically with 'flushInterval' delay
-# (in milliseconds) in between executions. Checkpoint flushes both ledger
-# entryLogs and ledger index pages to disk.
+# (in milliseconds) in between executions. Checkpoint flushes both ledger
+# entryLogs and ledger index pages to disk.
# Flushing entrylog and index files will introduce much random disk I/O.
# If separating journal dir and ledger dirs each on different devices,
# flushing would not affect performance. But if putting journal dir
@@ -273,16 +273,19 @@ serverTcpNoDelay=true
#############################################################################
# The journal format version to write.
-# Available formats are 1-5:
+# Available formats are 1-6:
# 1: no header
# 2: a header section was added
# 3: ledger key was introduced
# 4: fencing key was introduced
# 5: expanding header to 512 and padding writes to align sector size configured by `journalAlignmentSize`
-# By default, it is `4`. If you'd like to enable `padding-writes` feature, you can set journal version to `5`.
+# 6: persisting explicitLac is introduced
+# By default, it is `6`.
+# If you'd like to disable persisting ExplicitLac, you can set this config to < `6` and also
+# fileInfoFormatVersionToWrite should be set to 0. If there is mismatch then the serverconfig is considered invalid.
# You can disable `padding-writes` by setting journal version back to `4`. This feature is available in 4.5.0
# and onward versions.
-# journalFormatVersionToWrite=4
+journalFormatVersionToWrite=5
# Max file size of journal file, in mega bytes
# A new journal file will be created when the old one reaches the file size limitation
@@ -376,6 +379,16 @@ auditorPeriodicCheckInterval=604800
# to gain performance according your requirements.
openFileLimit=0
+# The fileinfo format version to write.
+# Available formats are 0-1:
+# 0: Initial version
+# 1: persisting explicitLac is introduced
+# By default, it is `1`.
+# If you'd like to disable persisting ExplicitLac, you can set this config to 0 and
+# also journalFormatVersionToWrite should be set to < 6. If there is mismatch then the
+# serverconfig is considered invalid.
+fileInfoFormatVersionToWrite=0
+
# Size of a index page in ledger cache, in bytes
# A larger index page can improve performance writing page to disk,
# which is efficent when you have small number of ledgers and these
@@ -437,9 +450,9 @@ readBufferSizeBytes=4096
# The number of bytes used as capacity for the write buffer. Default is 64KB.
writeBufferSizeBytes=65536
-# Specifies if entryLog per ledger is enabled/disabled. If it is enabled, then there would be a
-# active entrylog for each ledger. It would be ideal to enable this feature if the underlying
-# storage device has multiple DiskPartitions or SSD and if in a given moment, entries of fewer
+# Specifies if entryLog per ledger is enabled/disabled. If it is enabled, then there would be a
+# active entrylog for each ledger. It would be ideal to enable this feature if the underlying
+# storage device has multiple DiskPartitions or SSD and if in a given moment, entries of fewer
# number of active ledgers are written to a bookie.
# entryLogPerLedgerEnabled=false