You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "crossoverJie (via GitHub)" <gi...@apache.org> on 2024/12/19 04:55:24 UTC

[PR] [improve][monitor] Upgrade OTel to 1.45.0 [pulsar]

crossoverJie opened a new pull request, #23756:
URL: https://github.com/apache/pulsar/pull/23756

   ### Motivation
   
   Upgrade OpenTelemetry (OTel) libraries so that we stay up-to-date.
   
   ### Modifications
   
   - upgrade OTel to 1.45.0 and use other compatible libraries
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][monitor] Upgrade OTel to 1.45.0 [pulsar]

Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on code in PR #23756:
URL: https://github.com/apache/pulsar/pull/23756#discussion_r1893377465


##########
distribution/server/src/assemble/LICENSE.bin.txt:
##########
@@ -338,11 +338,12 @@ The Apache Software License, Version 2.0
     - io.prometheus-simpleclient_tracer_otel-0.16.0.jar
     - io.prometheus-simpleclient_tracer_otel_agent-0.16.0.jar
  * Prometheus exporter
-    - io.prometheus-prometheus-metrics-config-1.3.3.jar
-    - io.prometheus-prometheus-metrics-exporter-common-1.3.3.jar
-    - io.prometheus-prometheus-metrics-exporter-httpserver-1.3.3.jar
-    - io.prometheus-prometheus-metrics-exposition-formats-1.3.3.jar
-    - io.prometheus-prometheus-metrics-model-1.3.3.jar
+    - io.prometheus-prometheus-metrics-config-1.3.4.jar

Review Comment:
   is this part also included?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][monitor] Upgrade OTel to 1.45.0 [pulsar]

Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #23756:
URL: https://github.com/apache/pulsar/pull/23756#discussion_r1893429910


##########
distribution/server/src/assemble/LICENSE.bin.txt:
##########
@@ -338,11 +338,12 @@ The Apache Software License, Version 2.0
     - io.prometheus-simpleclient_tracer_otel-0.16.0.jar
     - io.prometheus-simpleclient_tracer_otel_agent-0.16.0.jar
  * Prometheus exporter
-    - io.prometheus-prometheus-metrics-config-1.3.3.jar
-    - io.prometheus-prometheus-metrics-exporter-common-1.3.3.jar
-    - io.prometheus-prometheus-metrics-exporter-httpserver-1.3.3.jar
-    - io.prometheus-prometheus-metrics-exposition-formats-1.3.3.jar
-    - io.prometheus-prometheus-metrics-model-1.3.3.jar
+    - io.prometheus-prometheus-metrics-config-1.3.4.jar

Review Comment:
   yes, `Check binary licenses` job  will check this license.
   https://github.com/apache/pulsar/actions/runs/12407619199/job/34645219668?pr=23756



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][monitor] Upgrade OTel to 1.45.0 [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #23756:
URL: https://github.com/apache/pulsar/pull/23756


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][monitor] Upgrade OTel to 1.45.0 [pulsar]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23756:
URL: https://github.com/apache/pulsar/pull/23756#issuecomment-2553338142

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23756?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 74.33%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2e3b877`)](https://app.codecov.io/gh/apache/pulsar/commit/2e3b877cd9c265c09218178c6dd02696055b6668?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 801 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/23756/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/23756?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #23756      +/-   ##
   ============================================
   + Coverage     73.57%   74.33%   +0.76%     
   + Complexity    32624    31767     -857     
   ============================================
     Files          1877     1838      -39     
     Lines        139502   143048    +3546     
     Branches      15299    16232     +933     
   ============================================
   + Hits         102638   106341    +3703     
   + Misses        28908    28347     -561     
   - Partials       7956     8360     +404     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23756/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.69% <ø> (+2.11%)` | :arrow_up: |
   | [systests](https://app.codecov.io/gh/apache/pulsar/pull/23756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.69% <ø> (-0.64%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.71% <ø> (+0.86%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 1002 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23756/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org