You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/07/19 02:25:06 UTC

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

GitHub user paul-guo- opened a pull request:

    https://github.com/apache/incubator-hawq/pull/802

    HAWQ-925. Set default locale, timezone & datastyle before running sql\u2026

    \u2026 command/file

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-guo-/incubator-hawq test3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/802.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #802
    
----
commit 1baa212228065c25372166e3c268fecc853fe6aa
Author: Paul Guo <pa...@gmail.com>
Date:   2016-07-18T11:48:54Z

    HAWQ-925. Set default locale, timezone & datastyle before running sql command/file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/802


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/802#discussion_r71265087
  
    --- Diff: src/test/feature/partition/ans/partition_negetive_and_basics.ans ---
    @@ -1609,10 +1605,10 @@ select * from j_1_prt_fb;
     (2 rows)
     
     alter table j split partition for(5) at (6);
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  exchanged partition "b" of relation "j" with relation "pg_temp_54636"
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  exchanged partition "b" of relation "j" with relation "pg_temp_43517"
    --- End diff --
    
    ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/802#discussion_r71265091
  
    --- Diff: src/test/feature/partition/ans/partition_negetive_and_basics.ans ---
    @@ -1609,10 +1605,10 @@ select * from j_1_prt_fb;
     (2 rows)
     
     alter table j split partition for(5) at (6);
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  exchanged partition "b" of relation "j" with relation "pg_temp_54636"
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  exchanged partition "b" of relation "j" with relation "pg_temp_43517"
     psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  dropped partition "b" for relation "j"
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  CREATE TABLE will create partition "j_1_prt_r613391202" for table "j"
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  CREATE TABLE will create partition "j_1_prt_r1064781686" for table "j"
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  CREATE TABLE will create partition "j_1_prt_r630513650" for table "j"
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:873: NOTICE:  CREATE TABLE will create partition "j_1_prt_r1373370768" for table "j"
    --- End diff --
    
    ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/802#discussion_r71265009
  
    --- Diff: src/test/feature/partition/ans/partition_negetive_and_basics.ans ---
    @@ -1089,7 +1085,7 @@ INSERT 0 1
     insert into ggg values (9, 9);
     INSERT 0 1
     insert into ggg values (10, 10);
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:566: ERROR:  no partition for partitioning key  (seg1 localhost:40000 pid=9097)
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:566: ERROR:  no partition for partitioning key  (seg5 localhost:40000 pid=172591)
    --- End diff --
    
    I think we should ignore this line?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/802#discussion_r71265085
  
    --- Diff: src/test/feature/partition/ans/partition_negetive_and_basics.ans ---
    @@ -1589,7 +1585,7 @@ insert into j select i from generate_series(1, 8) i;
     INSERT 0 8
     alter table j split partition for(1) at (2, 3) into (partition fa, partition
     fb);
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:870: NOTICE:  exchanged partition "a" of relation "j" with relation "pg_temp_54636"
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:870: NOTICE:  exchanged partition "a" of relation "j" with relation "pg_temp_43517"
    --- End diff --
    
    ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #802: HAWQ-925. Set default locale, timezone & datastyl...

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:

    https://github.com/apache/incubator-hawq/pull/802
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/802#discussion_r71277195
  
    --- Diff: src/test/feature/partition/ans/partition_negetive_and_basics.ans ---
    @@ -1089,7 +1085,7 @@ INSERT 0 1
     insert into ggg values (9, 9);
     INSERT 0 1
     insert into ggg values (10, 10);
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:566: ERROR:  no partition for partitioning key  (seg1 localhost:40000 pid=9097)
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:566: ERROR:  no partition for partitioning key  (seg5 localhost:40000 pid=172591)
    --- End diff --
    
    This difference seems to be eliminated by atmsort.pl.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #802: HAWQ-925. Set default locale, timezone & datastyl...

Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the issue:

    https://github.com/apache/incubator-hawq/pull/802
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #802: HAWQ-925. Set default locale, timezone & d...

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/802#discussion_r71265048
  
    --- Diff: src/test/feature/partition/ans/partition_negetive_and_basics.ans ---
    @@ -1321,7 +1317,7 @@ psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:690: NOTICE:  CREATE
     ALTER TABLE
     -- works - anonymous partition MPP-3350
     alter table hhh add partition end ('2010-02-01');
    -psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:693: NOTICE:  CREATE TABLE will create partition "hhh_1_prt_r418565524" for table "hhh"
    +psql:/tmp/TestPartition_TestPartitionNegativeAndBasics.sql:693: NOTICE:  CREATE TABLE will create partition "hhh_1_prt_r652516349" for table "hhh"
    --- End diff --
    
    I think we should ignore this line too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---