You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/06/28 21:21:17 UTC

[GitHub] [accumulo] keith-turner opened a new issue, #3553: User initiated compactions that throw an exception may hang

keith-turner opened a new issue, #3553:
URL: https://github.com/apache/accumulo/issues/3553

   **Describe the bug**
   
   A user initiated compactions that throw an exception may hang.
   
   
   **To Reproduce**
   
   Would like to try to recreated this with an integration test.  Maybe something like the following.
   
    1.  Create a an iterator that throws an IOException if file X exists in DFS
    2. Create file X
    3.  Initiate a user compaction with the above iterator configured.
    4. Sleep a bit (or devise a way to know if the iterator has run once and failed, it could create file Y when it fails and instead of sleeping wait for file Y to exist)
    5. Delete file X
    6. Wait for compaction to complete
   
   
   **Expected behavior**
   
   Compactions that throw an exception retry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] keith-turner commented on issue #3553: User initiated compactions that throw an exception may hang

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3553:
URL: https://github.com/apache/accumulo/issues/3553#issuecomment-1612126251

   2.1.1 I think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on issue #3553: User initiated compactions that throw an exception may hang

Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on issue #3553:
URL: https://github.com/apache/accumulo/issues/3553#issuecomment-1612123971

   @keith-turner In which version was this seen?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] dlmarion commented on issue #3553: User initiated compactions that throw an exception may hang

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #3553:
URL: https://github.com/apache/accumulo/issues/3553#issuecomment-1613052253

   I wrote a [test](https://github.com/dlmarion/accumulo/commit/c4110282a293387469a51ed98716af39d90fa161) that hangs.  On the Manager side, CompactionDriver.[isReady](https://github.com/apache/accumulo/blob/2.1/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java#L110) will continue to return a non-zero wait time as long as there are tablets which have a compactID that is less than the compactID for `this` compaction. For those tablets, the CompactionDriver continues to call TabletClientHandler.compact(), which goes through the motion each time of initiating a compaction on that tablet. 
   
   In InternalCompactionExecutor.InternalJob.[run](https://github.com/apache/accumulo/blob/2.1/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/InternalCompactionExecutor.java#L91) I cannot find anything that checks the FAILED status (or the COMPLETED status for that matter). A `completionCallback` is invoked (line 97) on success, but nothing happens on the failure path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] dlmarion closed issue #3553: User initiated compactions that throw an exception may hang

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed issue #3553: User initiated compactions that throw an exception may hang
URL: https://github.com/apache/accumulo/issues/3553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org